Skip to content

fix(frontend): No negative overflow when quoting signed integer #10331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vezenovm merged 19 commits into from
Nov 12, 2025
Merged

fix(frontend): No negative overflow when quoting signed integer #10331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1ab51e6
initial infra for roundtrip testing, just primitive types at the moment
vezenovm Oct 30, 2025
a08378c
comments
vezenovm Oct 30, 2025
80eb279
fmt
vezenovm Oct 30, 2025
9961e31
preserve integer type when unquoting
vezenovm Oct 30, 2025
62a12e9
remove unit as equality is in stdlib
vezenovm Oct 30, 2025
1151811
avoid neg overflow when quoting signed ints
vezenovm Oct 30, 2025
214b8d6
Merge branch 'mv/meta-roundtrip-testing' into mv/unquote-preserve-int…
vezenovm Oct 30, 2025
e406aaf
do not overflow on signed min
vezenovm Oct 30, 2025
4001ba0
Merge branch 'mv/unquote-preserve-int-type' into mv/no-neg-overflow-s…
vezenovm Oct 30, 2025
8153edb
merge conflcits w/ master
vezenovm Oct 30, 2025
57de008
Merge branch 'mv/unquote-preserve-int-type' into mv/no-neg-overflow-s…
vezenovm Oct 30, 2025
454397a
use From for u128
vezenovm Oct 30, 2025
29c8379
erge remote-tracking branch 'origin/mv/no-neg-overflow-signed-int-quo…
vezenovm Oct 30, 2025
ca41c17
Fix kind checking when an integer with a suffix is used in a type pos…
jfecher Nov 6, 2025
2aff43f
Allow integer suffixes in tuple field accesses
jfecher Nov 7, 2025
5d09254
Merge branch 'master' into mv/unquote-preserve-int-type
jfecher Nov 11, 2025
b3e21ec
Merge branch 'master' into mv/unquote-preserve-int-type
vezenovm Nov 11, 2025
47164a5
Merge branch 'mv/unquote-preserve-int-type' into mv/no-neg-overflow-s…
vezenovm Nov 11, 2025
35c246e
master merge conflicts
vezenovm Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions compiler/noirc_frontend/src/hir/comptime/value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,10 @@ impl Value {
if value < 0 {
vec![
Token::Minus,
Token::Int((-value as u128).into(), Some(IntegerTypeSuffix::I8)),
Token::Int(
u128::from(value.unsigned_abs()).into(),
Some(IntegerTypeSuffix::I8),
),
]
} else {
vec![Token::Int((value as u128).into(), Some(IntegerTypeSuffix::I8))]
Expand All @@ -588,7 +591,10 @@ impl Value {
if value < 0 {
vec![
Token::Minus,
Token::Int((-value as u128).into(), Some(IntegerTypeSuffix::I16)),
Token::Int(
u128::from(value.unsigned_abs()).into(),
Some(IntegerTypeSuffix::I16),
),
]
} else {
vec![Token::Int((value as u128).into(), Some(IntegerTypeSuffix::I16))]
Expand All @@ -598,7 +604,10 @@ impl Value {
if value < 0 {
vec![
Token::Minus,
Token::Int((-value as u128).into(), Some(IntegerTypeSuffix::I32)),
Token::Int(
u128::from(value.unsigned_abs()).into(),
Some(IntegerTypeSuffix::I32),
),
]
} else {
vec![Token::Int((value as u128).into(), Some(IntegerTypeSuffix::I32))]
Expand All @@ -608,7 +617,10 @@ impl Value {
if value < 0 {
vec![
Token::Minus,
Token::Int((-value as u128).into(), Some(IntegerTypeSuffix::I64)),
Token::Int(
u128::from(value.unsigned_abs()).into(),
Some(IntegerTypeSuffix::I64),
),
]
} else {
vec![Token::Int((value as u128).into(), Some(IntegerTypeSuffix::I64))]
Expand Down
46 changes: 23 additions & 23 deletions compiler/noirc_frontend/src/tests/meta_quote_roundtrip.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,27 +73,29 @@ proptest! {
assert_no_errors(&src);
}

// TODO(https://github.com/noir-lang/noir/issues/10328): Although it is a very low chance, all these tests have the possibility to be flakey
// #[test]
// fn roundtrip_i8_values(n in any::<i8>()) {
// let src = make_roundtrip_test("i8", n.to_string());
// assert_no_errors(&src);
// }
// #[test]
// fn roundtrip_i16_values(n in any::<i16>()) {
// let src = make_roundtrip_test("i16", n.to_string());
// assert_no_errors(&src);
// }
// #[test]
// fn roundtrip_i32_values(n in any::<i32>()) {
// let src = make_roundtrip_test("i32", n.to_string());
// assert_no_errors(&src);
// }
// #[test]
// fn roundtrip_i64_values(n in any::<i64>()) {
// let src = make_roundtrip_test("i64", n.to_string());
// assert_no_errors(&src);
// }
#[test]
fn roundtrip_i8_values(n in any::<i8>()) {
let src = make_roundtrip_test("i8", n.to_string());
assert_no_errors(&src);
}

#[test]
fn roundtrip_i16_values(n in any::<i16>()) {
let src = make_roundtrip_test("i16", n.to_string());
assert_no_errors(&src);
}

#[test]
fn roundtrip_i32_values(n in any::<i32>()) {
let src = make_roundtrip_test("i32", n.to_string());
assert_no_errors(&src);
}

#[test]
fn roundtrip_i64_values(n in any::<i64>()) {
let src = make_roundtrip_test("i64", n.to_string());
assert_no_errors(&src);
}
}

#[test]
Expand All @@ -102,9 +104,7 @@ fn roundtrip_zero_field() {
assert_no_errors(&src);
}

// TODO(https://github.com/noir-lang/noir/issues/10328)
#[test]
#[ignore]
fn roundtrip_i64_min() {
let src = make_roundtrip_test("i64", i64::MIN.to_string());
assert_no_errors(&src);
Expand Down
Loading