Skip to content

chore: green light Brillig for audit#10376

Merged
jfecher merged 6 commits intomasterfrom
gd/green_light_brillig
Nov 12, 2025
Merged

chore: green light Brillig for audit#10376
jfecher merged 6 commits intomasterfrom
gd/green_light_brillig

Conversation

@guipublic
Copy link
Contributor

Description

Problem*

Audit preparation

Summary*

I added some unit tests and improved the code documentation.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: c4fbea1 Previous: 60bfcf2 Ratio
rollup-block-root-single-tx 0.003 s 0.002 s 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: b6b3202 Previous: 60bfcf2 Ratio
test_report_zkpassport_noir-ecdsa_ 2 s 1 s 2
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@jfecher
Copy link
Contributor

jfecher commented Nov 10, 2025

FYI @guipublic formatting issues here

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 3ea1e14 Previous: 36ecc83 Ratio
rollup-tx-base-private 28.16 s 21.86 s 1.29

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@guipublic guipublic requested a review from TomAFrench November 11, 2025 18:27
@jfecher jfecher enabled auto-merge November 12, 2025 13:16
@jfecher jfecher added this pull request to the merge queue Nov 12, 2025
Merged via the queue into master with commit 62a4432 Nov 12, 2025
132 checks passed
@jfecher jfecher deleted the gd/green_light_brillig branch November 12, 2025 13:36
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 13, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: remove `local_annotations` from flattening
(noir-lang/noir#10483)
chore: better error recovery for multiple mut in pattern
(noir-lang/noir#10490)
chore(frontend): Tuple pattern tests and remove confusing arity error
(noir-lang/noir#10480)
chore: monomorphizer public fields
(noir-lang/noir#9979)
chore: remove a bunch of dummy definitions
(noir-lang/noir#10482)
feat(ssa): Limit the number of steps executed by the SSA interpreter
during constant folding (noir-lang/noir#10481)
fix: remove saturation from loop bound increments
(noir-lang/noir#10479)
fix(print): Print enums (noir-lang/noir#10472)
fix(frontend): No negative overflow when quoting signed integer
(noir-lang/noir#10331)
chore: green light Brillig for audit
(noir-lang/noir#10376)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants