chore: remove a bunch of dummy definitions#10482
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: e7afcdb | Previous: 62a4432 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
498 s |
371 s |
1.34 |
test_report_zkpassport_noir_rsa_ |
1 s |
0 s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: e7afcdb | Previous: 62a4432 | Ratio |
|---|---|---|---|
rollup-checkpoint-merge |
0.004 s |
0.003 s |
1.33 |
sha512-100-bytes |
0.059 s |
0.049 s |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: e7afcdb | Previous: 62a4432 | Ratio |
|---|---|---|---|
perfectly_parallel_batch_inversion_opcodes |
2782967 ns/iter (± 3279) |
2264195 ns/iter (± 1976) |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: remove `local_annotations` from flattening (noir-lang/noir#10483) chore: better error recovery for multiple mut in pattern (noir-lang/noir#10490) chore(frontend): Tuple pattern tests and remove confusing arity error (noir-lang/noir#10480) chore: monomorphizer public fields (noir-lang/noir#9979) chore: remove a bunch of dummy definitions (noir-lang/noir#10482) feat(ssa): Limit the number of steps executed by the SSA interpreter during constant folding (noir-lang/noir#10481) fix: remove saturation from loop bound increments (noir-lang/noir#10479) fix(print): Print enums (noir-lang/noir#10472) fix(frontend): No negative overflow when quoting signed integer (noir-lang/noir#10331) chore: green light Brillig for audit (noir-lang/noir#10376) END_COMMIT_OVERRIDE
2 participants
Description
Problem
No issue.
Summary
I noticed
CrateId::Dummywasn't used in a lot of places so I decided to remove it. It then led to more refactors:TypeId::dummy()which was used for reporting a type mismatch where we expect a struct and not another type. The way this error message was formed was using an actual type which meant we needed a dummy ID. I changed this so the expected type is a string, so we can say "expected: struct" instead, which might actually read better (though in practice these error will never trigger unless we have a bug in the compiler)internerargumentsAdditional Context
The remaining dummy is
DefinitionId::dummy_idbut that's much harder to remove so I'll leave it for a follow-up PR, or maybe not do it.User Documentation
Check one:
PR Checklist
cargo fmton default settings.