Skip to content

chore: remove local_annotations from flattening#10483

Merged
jfecher merged 1 commit intomasterfrom
tf/remove-local-annotations
Nov 12, 2025
Merged

chore: remove local_annotations from flattening#10483
jfecher merged 1 commit intomasterfrom
tf/remove-local-annotations

Conversation

@TomAFrench
Copy link
Copy Markdown
Member

@TomAFrench TomAFrench commented Nov 11, 2025

Description

Problem

Resolves

Summary

This PR resolves the cantina finding https://cantina.xyz/code/e97ed859-f2c3-41ca-8457-de28d871530a/findings?finding=5

Additional Context

User Documentation

Check one:

  • No user documentation needed.
  • Changes in docs/ included in this PR.
  • [For Experimental Features] Changes in docs/ to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 15b52a5 Previous: fe0bfa0 Ratio
test_report_zkpassport_noir_rsa_ 1 s 0 s +∞

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 15b52a5 Previous: fe0bfa0 Ratio
rollup-block-root-single-tx 0.003 s 0.002 s 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@TomAFrench TomAFrench requested a review from a team November 12, 2025 13:49
Copy link
Copy Markdown
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfecher jfecher added this pull request to the merge queue Nov 12, 2025
Merged via the queue into master with commit b34828f Nov 12, 2025
134 checks passed
@jfecher jfecher deleted the tf/remove-local-annotations branch November 12, 2025 19:11
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 13, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: remove `local_annotations` from flattening
(noir-lang/noir#10483)
chore: better error recovery for multiple mut in pattern
(noir-lang/noir#10490)
chore(frontend): Tuple pattern tests and remove confusing arity error
(noir-lang/noir#10480)
chore: monomorphizer public fields
(noir-lang/noir#9979)
chore: remove a bunch of dummy definitions
(noir-lang/noir#10482)
feat(ssa): Limit the number of steps executed by the SSA interpreter
during constant folding (noir-lang/noir#10481)
fix: remove saturation from loop bound increments
(noir-lang/noir#10479)
fix(print): Print enums (noir-lang/noir#10472)
fix(frontend): No negative overflow when quoting signed integer
(noir-lang/noir#10331)
chore: green light Brillig for audit
(noir-lang/noir#10376)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants