Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V18.15.0 proposal #46920

Merged
merged 93 commits into from
Mar 7, 2023
Merged

V18.15.0 proposal #46920

merged 93 commits into from
Mar 7, 2023

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Mar 3, 2023

2023-03-07, Version 18.15.0 'Hydrogen' (LTS), @BethGriggs prepared by @juanarbol

Notable Changes

  • [63563f8a7a] - doc,lib,src,test: rename --test-coverage (Colin Ihrig) #46017
  • [28a775b32f] - test_runner: add initial code coverage support (Colin Ihrig) #46017
  • [4d50db14b3] - (SEMVER-MINOR) test_runner: add reporters (Moshe Atlow) #45712
  • [643545ab79] - (SEMVER-MINOR) fs: add statfs() functions (Colin Ihrig) #46358
  • [110ead9abb] - (SEMVER-MINOR) vm: expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320
  • [02632b42cf] - (SEMVER-MINOR) v8: support gc profile (theanarkh) #46255
  • [f09b838408] - (SEMVER-MINOR) src,lib: add constrainedMemory API for process (theanarkh) #46218
  • [cb5bb12422] - (SEMVER-MINOR) buffer: add isAscii method (Yagiz Nizipli) #46046

Commits

  • [6f91c8e2ae] - benchmark: add trailing commas (Antoine du Hamel) #46370
  • [d0b9be21eb] - benchmark: remove buffer benchmarks redundancy (Brian White) #45735
  • [6468f30d0d] - benchmark: introduce benchmark combination filtering (Brian White) #45735
  • [cb5bb12422] - (SEMVER-MINOR) buffer: add isAscii method (Yagiz Nizipli) #46046
  • [ec61bb04c0] - build: export more OpenSSL symbols on Windows (Mohamed Akram) #45486
  • [7bae4333ce] - build: fix MSVC 2022 Release compilation (Vladimir Morozov (REDMOND)) #46228
  • [0f5f2d4470] - crypto: include hmac.h in crypto_util.h (Adam Langley) #46279
  • [91ece4161b] - crypto: avoid hang when no algorithm available (Richard Lau) #46237
  • [492fc95bdf] - deps: V8: cherry-pick 90be99fab31c (Michaël Zasso) #46646
  • [732c77e3d9] - deps: update acorn to 8.8.2 (Node.js GitHub Bot) #46363
  • [8582f99ffb] - deps: update to uvwasi 0.0.15 (Colin Ihrig) #46253
  • [5453cd9940] - deps: V8: cherry-pick bf0bd4868dde (Michaël Zasso) #45908
  • [3ea53c5dc8] - deps: V8: cherry-pick c875e86df1d7 (sepehrst) #46501
  • [c04808de4b] - doc: correct the sed command for macOS in release process docs (Juan José) #46397
  • [8113220690] - doc: pass string to textEncoder.encode as input (Deokjin Kim) #46421
  • [129dccf5d2] - doc: add tip for session.post function (theanarkh) #46354
  • [919e581732] - doc: add documentation for socket.destroySoon() (Luigi Pinca) #46337
  • [fc15ac95a5] - doc: fix commit message using test instead of deps (Tony Gorez) #46313
  • [d153a93200] - doc: add v8 fast api contribution guidelines (Yagiz Nizipli) #46199
  • [dbf082d082] - doc: fix small typo error (0xflotus) #46186
  • [94421b4cfe] - doc: mark some parameters as optional in webstreams (Deokjin Kim) #46269
  • [5adb743511] - doc: update output of example in events.getEventListeners (Deokjin Kim) #46268
  • [63563f8a7a] - doc,lib,src,test: rename --test-coverage (Colin Ihrig) #46017
  • [4e88c7c813] - esm: delete preload mock test (Geoffrey Booth) #46402
  • [643545ab79] - (SEMVER-MINOR) fs: add statfs() functions (Colin Ihrig) #46358
  • [5019b5473f] - http: res.setHeaders first implementation (Marco Ippolito) #46109
  • [76622c4c60] - inspector: allow opening inspector when NODE_V8_COVERAGE is set (Moshe Atlow) #46113
  • [92f0747e03] - meta: update AUTHORS (Node.js GitHub Bot) #46399
  • [795251bc6f] - meta: update AUTHORS (Node.js GitHub Bot) #46303
  • [8865424c31] - meta: add .mailmap entry (Rich Trott) #46303
  • [5ed679407b] - meta: move evanlucas to emeritus (Evan Lucas) #46274
  • [403df210ac] - module: move test reporter loading (Geoffrey Booth) #45923
  • [2f7319e387] - readline: fix detection of carriage return (Antoine du Hamel) #46306
  • [73a8f46c4d] - Revert "src: let http2 streams end after session close" (Santiago Gimeno) #46721
  • [30d783f91a] - src: stop tracing agent before shutting down libuv (Santiago Gimeno) #46380
  • [1508d90fda] - src: get rid of fp arithmetic in ParseIPv4Host (Tobias Nießen) #46326
  • [bdb793a082] - src: use UNREACHABLE instead of CHECK(falsy) (Tobias Nießen) #46317
  • [116a33649b] - src: add support for ETW stack walking (José Dapena Paz) #46203
  • [b06298c98e] - src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid (Miguel Teixeira) #46227
  • [26f41b041c] - src: fix c++ exception on bad command line arg (Ben Noordhuis) #46290
  • [14da89f41a] - src: remove unreachable UNREACHABLE (Tobias Nießen) #46281
  • [18c4dd004b] - src: replace custom ASCII validation with simdutf one (Anna Henningsen) #46271
  • [cde375510f] - src: replace unreachable code with static_assert (Tobias Nießen) #46250
  • [f389b2f3fc] - src: use explicit C++17 fallthrough (Tobias Nießen) #46251
  • [8adaa1333c] - src: use CreateEnvironment instead of inlining its code where possible (Anna Henningsen) #45886
  • [f09b838408] - (SEMVER-MINOR) src,lib: add constrainedMemory API for process (theanarkh) #46218
  • [63e92eae63] - stream: remove brandchecks from stream duplexify (Debadree Chatterjee) #46315
  • [3acfe9bf92] - stream: fix readable stream as async iterator function (Erick Wendel) #46147
  • [de64315ccb] - test: fix WPT title when no META title is present (Filip Skokan) #46804
  • [162e3400ff] - test: fix default WPT titles (Filip Skokan) #46778
  • [5f422c4d70] - test: add WPTRunner support for variants and generating WPT reports (Filip Skokan) #46498
  • [4f5aff2557] - test: fix tap parser fails if a test logs a number (Pulkit Gupta) #46056
  • [32b020cf84] - test: fix tap escaping with and without --test (Pulkit Gupta) #46311
  • [f2bba1bcdb] - test: add trailing commas in test/node-api (Antoine du Hamel) #46384
  • [f2ebe66fda] - test: add trailing commas in test/message (Antoine du Hamel) #46372
  • [ed564a9985] - test: add trailing commas in test/pseudo-tty (Antoine du Hamel) #46371
  • [e4437dd409] - test: set common.bits to 64 for loong64 (Shi Pujin) #45383
  • [9d40aef736] - test: s390x zlib test case fixes (Adam Majer) #46367
  • [ed3fb52716] - test: fix logInTimeout is not function (theanarkh) #46348
  • [d05b0771be] - test: avoid trying to call sysctl directly (Adam Majer) #46366
  • [041aac3bbd] - test: avoid left behind child processes (Richard Lau) #46276
  • [837ddcb322] - test: add failing test for readline with carriage return (Alec Mev) #46075
  • [75b8db41c6] - test: reduce fs-write-optional-params flakiness (LiviaMedeiros) #46238
  • [c0d3fdaf63] - test,crypto: add CFRG curve vectors to wrap/unwrap tests (Filip Skokan) #46406
  • [f328f7b15e] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #46267
  • [1ef3c53e24] - test_runner: better handle async bootstrap errors (Colin Ihrig) #46720
  • [0a690efb76] - test_runner: add describe.only and it.only shorthands (Richie McColl) #46604
  • [28a1317efe] - test_runner: bootstrap reporters before running tests (Moshe Atlow) #46737
  • [cd3aaa8fac] - test_runner: emit test-only diagnostic warning (Richie McColl) #46540
  • [c19fa45a65] - test_runner: centralize CLI option handling (Colin Ihrig) #46707
  • [0898145e37] - test_runner: display skipped tests in spec reporter output (Richie McColl) #46651
  • [894d7117fa] - test_runner: parse non-ascii character correctly (Mert Can Altın) #45736
  • [5b3c606626] - test_runner: flatten TAP output when running using --test (Moshe Atlow) #46440
  • [391ff0dba4] - test_runner: allow nesting test within describe (Moshe Atlow) #46544
  • [ba784e87b4] - test_runner: fix missing test diagnostics (Moshe Atlow) #46450
  • [c5f16fb5fb] - test_runner: top-level diagnostics not ommited when running with --test (Pulkit Gupta) #46441
  • [28a775b32f] - test_runner: add initial code coverage support (Colin Ihrig) #46017
  • [0d999e373a] - test_runner: make built in reporters internal (Colin Ihrig) #46092
  • [79f4b426fe] - test_runner: report file in test runner events (Moshe Atlow) #46030
  • [4d50db14b3] - (SEMVER-MINOR) test_runner: add reporters (Moshe Atlow) #45712
  • [5fdf374c74] - test_runner: avoid swallowing of asynchronously thrown errors (MURAKAMI Masahiko) #45264
  • [23b875806c] - test_runner: update comment to comply with eslint no-fallthrough rule (Antoine du Hamel) #46258
  • [00c5495aa3] - tools: update eslint to 8.33.0 (Node.js GitHub Bot) #46400
  • [37a6ce1120] - tools: update doc to [email protected] [email protected] (Node.js GitHub Bot) #46364
  • [1eaafc7db4] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #46398
  • [a97774603b] - tools: require more trailing commas (Antoine du Hamel) #46346
  • [03e244a59b] - tools: update lint-md-dependencies (Node.js GitHub Bot) #46302
  • [60d714e0c3] - tools: allow icutrim.py to run on python2 (Michael Dawson) #46263
  • [b7950f50de] - tools: update eslint to 8.32.0 (Node.js GitHub Bot) #46258
  • [08bafc84f6] - url: refactor to use more primordials (Antoine du Hamel) #45966
  • [02632b42cf] - (SEMVER-MINOR) v8: support gc profile (theanarkh) #46255
  • [110ead9abb] - (SEMVER-MINOR) vm: expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

@nodejs-github-bot

This comment was marked as off-topic.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Mar 3, 2023
juanarbol added a commit that referenced this pull request Mar 3, 2023
Notable Changes

buffer:
  * add isAscii method (Yagiz Nizipli) #46046
fs:
  * add statfs() functions (Colin Ihrig) #46358
src,lib:
  * add constrainedMemory API for process (theanarkh) #46218
v8:
  * support gc profile (theanarkh) #46255
vm:
  * expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
@juanarbol juanarbol added release Issues and PRs related to Node.js releases. and removed doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Mar 3, 2023
@nodejs-github-bot

This comment was marked as outdated.

juanarbol added a commit that referenced this pull request Mar 3, 2023
Notable Changes:

buffer:
  * add isAscii method (Yagiz Nizipli) #46046
fs:
  * add statfs() functions (Colin Ihrig) #46358
src,lib:
  * add constrainedMemory API for process (theanarkh) #46218
v8:
  * support gc profile (theanarkh) #46255
vm:
  * expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
@nodejs-github-bot

This comment was marked as outdated.

@MoLow
Copy link
Member

MoLow commented Mar 3, 2023

@juanarbol any reason #46839 is not in the release?
it is waiting for quite a while (#46017 (comment), #46092 (comment), etc)
the delta and the number of conflicts in the area are continuously growing blocking other PRS from landing clearly on further releases

@juanarbol
Copy link
Member Author

juanarbol commented Mar 3, 2023

@juanarbol any reason #46839 is not in the release? it is waiting for quite a while (#46017 (comment), #46092 (comment), etc) the delta and the number of conflicts in the area are continuously growing blocking other PRS from landing clearly on further releases

Not intended -maybe I forgot to add it in my notes, sorry, really sorry-, let me land it and re-run CI :) Thanks for the heads up. Landed! Thanks again

juanarbol added a commit that referenced this pull request Mar 3, 2023
Notable Changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
@nodejs-github-bot

This comment was marked as outdated.

@ml1nk
Copy link

ml1nk commented Mar 3, 2023

@juanarbol What about #46721 to fix #46234?

@panva
Copy link
Member

panva commented Mar 3, 2023

Please add #46767

@BPScott
Copy link

BPScott commented Mar 3, 2023

Would it be possible to include 1d5058d from #46646, in order to mitigate the breaking changes to ICU72 that were introduced in 18.13, as detailed in #46123?

@sepehrst
Copy link

sepehrst commented Mar 4, 2023

The description contains incorrect reference to the node pull request #2 which is picked up from the original commit message (That is actually a reference to the fork's pulls request.)
Sorry for pushing with inappropriate commit message, and not noticing it in the first place, that is on me for sure, But unfortunately It wasn't noticed/blocked/corrected by node's repo automation/whatever mechanism along the way.

@juanarbol, I'm not sure what the procedures would be to correct this, But I have to express my apologies for the the inconveniences I'm caused of.

@juanarbol
Copy link
Member Author

juanarbol commented Mar 5, 2023

The description contains incorrect reference to the node pull request #2 which is picked up from the original commit message (That is actually a reference to the fork's pulls request.) Sorry for pushing with inappropriate commit message, and not noticing it in the first place, that is on me for sure, But unfortunately It wasn't noticed/blocked/corrected by node's repo automation/whatever mechanism along the way.

@juanarbol, I'm not sure what the procedures would be to correct this, But I have to express my apologies for the the inconveniences I'm caused of.

I don't see any problem amending the commit message; I would like to know from other @nodejs/releasers

@sepehrst could you please give me the right commit message?

@sepehrst
Copy link

sepehrst commented Mar 5, 2023

@sepehrst could you please give me the right commit message?

Just the (#2) needs to be removed from the commit message.
The right commit message would be: deps: V8: cherry-pick c875e86df1d7

@juanarbol
Copy link
Member Author

juanarbol commented Mar 5, 2023

@sepehrst could you please give me the right commit message?

Just the (#2) needs to be removed from the commit message. The right commit message would be: deps: V8: cherry-pick c875e86df1d7

Yeah, I can do that :)

@juanarbol What about #46721 to fix #46234?

Landed!

Please add #46767

Landed!

Would it be possible to include 1d5058d from #46646, in order to mitigate the breaking changes to ICU72 that were introduced in 18.13, as detailed in #46123?

Landed!

Thank you all for the heads-up! And the nice catches! Appreciated, this release will be better <3

sepehrst and others added 3 commits March 4, 2023 23:03
Original commit message:

    [bigint] Convert BigInt property names to decimal

    Hexadecimal/octal/binary BigInt property names should be converted
    to decimal, i.e. the following object literals should all be equivalent:
    var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.

    Test case by [email protected], uploaded at
    https://chromium-review.googlesource.com/c/v8/v8/+/3634937

    Fixed: v8:10600
    Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Jakob Kummerow <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#80490}

Refs: v8/v8@c875e86
PR-URL: #46501
Refs: v8/v8@c875e86
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: #46109
Backport-PR-URL: #46365
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
We had a number of places in which we created an `Environment` instance
by performing each step in `CreateEnvironment` manually. Instead,
just call the function itself.

PR-URL: #45886
Backport-PR-URL: #46330
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
richiemccoll and others added 7 commits March 4, 2023 23:03
PR-URL: #46604
Backport-PR-URL: #46839
Fixes: #46562
Reviewed-By: Moshe Atlow <[email protected]>
The test runner is bootstrapped synchronously, with the exception
of importing custom reporters. To better handle asynchronously
throw errors, this commit introduces an internal error type that
can be checked for from the test runner's uncaughtException
handler.

After #46707 and this change
land, the other throw statement in the uncaughtException handler
can be removed. This will allow the test runner to handle errors
thrown from outside of tests (which currently prevents the test
runner from reporting results).

PR-URL: #46720
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
This reverts commit dee882e.
Moved the test that demonstrated what this commit was fixing to the
`known_issues` folder.

Fixes: #46234
PR-URL: #46721
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Original commit message:

    [intl] Revert date formatting behavior change from ICU 72

    Replace U+202F with U+0020 after formatting date. This lets websites
    continue to work without any changes.

    This matches Firefox behavior, according to
    https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17.

    Bug: chromium:1414292, chromium:1401829, chromium:1392814
    Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675
    Commit-Queue: Adam Klein <[email protected]>
    Reviewed-by: Shu-yu Guo <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#85757}

Refs: v8/v8@90be99f
PR-URL: #46646
Refs: #46123
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #46498
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Backport-PR-URL: #46767
PR-URL: #46778
Backport-PR-URL: #46767
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #46804
Backport-PR-URL: #46767
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@juanarbol juanarbol force-pushed the v18.15.0-proposal branch 2 times, most recently from c1d6a15 to fceac82 Compare March 5, 2023 04:18
juanarbol added a commit that referenced this pull request Mar 5, 2023
Notable changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
@nodejs-github-bot

This comment was marked as outdated.

Notable changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
@juanarbol

This comment was marked as off-topic.

@richardlau
Copy link
Member

$ ncu-ci citgm 3118 3131

The stand outs from that are [email protected] and [email protected]. [email protected] at least was released after Node.js 18.14.1 was. I'd suggest running another CITGM for 18.14.1 and using that as the baseline to compare the CITGM for this PR against.

@juanarbol
Copy link
Member Author

$ ncu-ci citgm 3135 3131

FAILURE: 43 failures in 3131 not present in 3135


┌────────────────────────┬───────────────────┬─────────────────────────┬─────────────────────────┬───────────────────────┬─────────────────────────┬──────────────────────┬─────────────────┐
│        (index)         │         0         │            1            │            2            │           3           │            4            │          5           │        6        │
├────────────────────────┼───────────────────┼─────────────────────────┼─────────────────────────┼───────────────────────┼─────────────────────────┼──────────────────────┼─────────────────┤
│       win-vs2019       │  'async-v3.2.4'   │  'body-parser-v1.20.2'  │  'prom-client-v14.1.1'  │                       │                         │                      │                 │
│ fedora-last-latest-x64 │  'bcrypt-v5.1.0'  │    'bluebird-v3.7.2'    │      'ava-v5.2.0'       │   'fastify-v4.14.0'   │     'level-v8.0.0'      │    'jest-v29.4.3'    │                 │
│     rhel8-ppc64le      │ 'esprima-v4.0.1'  │   'csv-parser-v3.0.0'   │    'fastify-v4.14.0'    │   'resolve-v1.22.1'   │  'prom-client-v14.1.1'  │   'rimraf-v4.3.0'    │ 'rewire-v6.0.0' │
│      rhel8-s390x       │ 'fastify-v4.14.0' │     'rewire-v6.0.0'     │     'rimraf-v4.3.0'     │ 'tough-cookie-v4.1.2' │ 'torrent-stream-v1.2.1' │                      │                 │
│      aix72-ppc64       │ 'fastify-v4.14.0' │     'rimraf-v4.3.0'     │ 'torrent-stream-v1.2.1' │                       │                         │                      │                 │
│       rhel8-x64        │  'jest-v29.4.3'   │ 'torrent-stream-v1.2.1' │                         │                       │                         │                      │                 │
│      debian10-x64      │  'async-v3.2.4'   │     'pino-v8.11.0'      │  'serialport-v10.5.0'   │    'jest-v29.4.3'     │                         │                      │                 │
│     ubuntu1804-64      │  'async-v3.2.4'   │     'pino-v8.11.0'      │  'serialport-v10.5.0'   │    'jest-v29.4.3'     │ 'torrent-stream-v1.2.1' │                      │                 │
│   fedora-latest-x64    │ 'fastify-v4.14.0' │    'inherits-v2.0.4'    │     'jest-v29.4.3'      │  'ember-cli-v4.11.0'  │   'leveldown-v6.1.1'    │ 'serialport-v10.5.0' │                 │
│        osx1015         │ 'fastify-v4.14.0' │   'ember-cli-v4.11.0'   │                         │                       │                         │                      │                 │
└────────────────────────┴───────────────────┴─────────────────────────┴─────────────────────────┴───────────────────────┴─────────────────────────┴──────────────────────┴─────────────────┘

@juanarbol
Copy link
Member Author

juanarbol commented Mar 7, 2023

$ ncu-ci citgm 3135 3136

FAILURE: 19 failures in 3136 not present in 3135
┌────────────────────────┬─────────────────────────┬─────────────────────────┬──────────────────────┐
│        (index)         │            0            │            1            │          2           │
├────────────────────────┼─────────────────────────┼─────────────────────────┼──────────────────────┤
│      rhel8-s390x       │ 'torrent-stream-v1.2.1' │                         │                      │
│ fedora-last-latest-x64 │     'bcrypt-v5.1.0'     │    'undici-v5.20.0'     │                      │
│      aix72-ppc64       │     'async-v3.2.4'      │ 'torrent-stream-v1.2.1' │                      │
│       rhel8-x64        │ 'torrent-stream-v1.2.1' │                         │                      │
│       win-vs2019       │     'async-v3.2.4'      │    'fastify-v4.14.1'    │                      │
│      debian10-x64      │     'bcrypt-v5.1.0'     │   'leveldown-v6.1.1'    │                      │
│     ubuntu1804-64      │     'async-v3.2.4'      │     'pino-v8.11.0'      │ 'serialport-v10.5.0' │
│     rhel8-ppc64le      │     'level-v8.0.0'      │     'vinyl-v3.0.0'      │     'ws-v8.12.1'     │
│   fedora-latest-x64    │     'async-v3.2.4'      │   'ember-cli-v4.11.0'   │                      │
│        osx1015         │   'ember-cli-v4.11.0'   │                         │                      │
└────────────────────────┴─────────────────────────┴─────────────────────────┴──────────────────────┘

@juanarbol juanarbol merged commit a94966f into v18.x Mar 7, 2023
@juanarbol juanarbol deleted the v18.15.0-proposal branch March 7, 2023 19:24
juanarbol added a commit that referenced this pull request Mar 7, 2023
juanarbol added a commit that referenced this pull request Mar 7, 2023
Notable changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.