test_runner: better handle async bootstrap errors #46720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
cjihrig
force-pushed
the
reporter-err
branch
from
576da3f
to
d63041d
Compare
MoLow
approved these changes
Feb 18, 2023
jasnell
approved these changes
Feb 20, 2023
aduh95
reviewed
Feb 20, 2023
lib/internal/test_runner/utils.js
Outdated
Comment on lines
169
to
176
| try { | ||
| const reportersMap = await getReportersMap(reporters, destinations); | ||
| for (let i = 0; i < reportersMap.length; i++) { | ||
| const { reporter, destination } = reportersMap[i]; | ||
| compose(testsStream, reporter).pipe(destination); | ||
| } | ||
| } catch (err) { | ||
| throw new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure); |
There was a problem hiding this comment.
nit: we should probably only catch async errors, and not errors that might happen in the for loop.
Suggested change
| try { | |
| const reportersMap = await getReportersMap(reporters, destinations); | |
| for (let i = 0; i < reportersMap.length; i++) { | |
| const { reporter, destination } = reportersMap[i]; | |
| compose(testsStream, reporter).pipe(destination); | |
| } | |
| } catch (err) { | |
| throw new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure); | |
| const reportersMap = await PromisePrototypeThen( | |
| getReportersMap(reporters, destinations), undefined, | |
| (err) => PromiseReject(new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure)), | |
| ); | |
| for (let i = 0; i < reportersMap.length; i++) { | |
| const { reporter, destination } = reportersMap[i]; | |
| compose(testsStream, reporter).pipe(destination); |
or
Suggested change
| try { | |
| const reportersMap = await getReportersMap(reporters, destinations); | |
| for (let i = 0; i < reportersMap.length; i++) { | |
| const { reporter, destination } = reportersMap[i]; | |
| compose(testsStream, reporter).pipe(destination); | |
| } | |
| } catch (err) { | |
| throw new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure); | |
| let reportersMap; | |
| try { | |
| reportersMap = await getReportersMap(reporters, destinations); | |
| } catch(err) { | |
| throw new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure); | |
| } | |
| for (let i = 0; i < reportersMap.length; i++) { | |
| const { reporter, destination } = reportersMap[i]; | |
| compose(testsStream, reporter).pipe(destination); |
There was a problem hiding this comment.
By the time this code is reached, getReportersMap() has made everything async from the test runner's point of view.
cjihrig
force-pushed
the
reporter-err
branch
from
d63041d
to
1578a7d
Compare
26 tasks
MoLow
approved these changes
Feb 21, 2023
MoLow
added
author ready
MoLow
reviewed
Feb 21, 2023
This was referenced Feb 22, 2023
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After nodejs#46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results).
cjihrig
force-pushed
the
reporter-err
branch
from
1578a7d
to
59b149d
Compare
MoLow
approved these changes
Feb 24, 2023
benjamingr
approved these changes
Feb 24, 2023
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0c90be9 |
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Feb 25, 2023
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After nodejs#46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results). PR-URL: nodejs#46720 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Feb 25, 2023
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After nodejs#46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results). PR-URL: nodejs#46720 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Feb 25, 2023
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After nodejs#46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results). PR-URL: nodejs#46720 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After #46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results). PR-URL: #46720 Backport-PR-URL: #46839 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After #46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results). PR-URL: #46720 Backport-PR-URL: #46839 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After #46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results). PR-URL: #46720 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's
'uncaughtException'handler.After #46707 and this change land, the other
throwstatement in the'uncaughtException'handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results).