-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.x backport] http: res setheaders #46365
Closed
marco-ippolito
wants to merge
2
commits into
nodejs:v18.x-staging
from
marco-ippolito:backport/18.x-setheaders
Closed
[18.x backport] http: res setheaders #46365
marco-ippolito
wants to merge
2
commits into
nodejs:v18.x-staging
from
marco-ippolito:backport/18.x-setheaders
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
http
Issues or PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
v18.x
Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
labels
Jan 26, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 30, 2023
juanarbol
force-pushed
the
v18.x-staging
branch
from
January 31, 2023 13:17
7351221
to
fcfde34
Compare
PR-URL: nodejs#46109 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito
force-pushed
the
backport/18.x-setheaders
branch
from
February 21, 2023 16:49
783a822
to
e835966
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This was referenced Feb 25, 2023
This was referenced Feb 28, 2023
juanarbol
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Mar 1, 2023
PR-URL: nodejs#46109 Backport-PR-URL: nodejs#46365 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Landed in ba71900 |
15 tasks
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
PR-URL: #46109 Backport-PR-URL: #46365 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #46109
As requested by @juanarbol #46109 (comment)