Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools,doc: fix commit message using test instead of deps #46313

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

tony-go
Copy link
Member

@tony-go tony-go commented Jan 23, 2023

I chatted with @RaisinTen the other day, and he mentioned that the commit title we propose in the documentation should contain the label test and not deps as postject is a part of test fixtures.

I took this opportunity to change a few things.

Let me know ^^

@targos @nodejs/single-executable

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 23, 2023
@RaisinTen
Copy link
Contributor

Could you also change both of these to test

subsystem: deps
label: dependencies
?

@tony-go
Copy link
Member Author

tony-go commented Jan 23, 2023

Could you also change both of these to test

subsystem: deps
label: dependencies

?

Didn't notice it, thanks a lot @RaisinTen ^^

doc/contributing/maintaining-postject.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-postject.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-postject.md Outdated Show resolved Hide resolved
@tony-go tony-go force-pushed the fix-maintaining-postject-doc branch from 24b80e1 to 14c9c16 Compare January 23, 2023 09:55
@tony-go
Copy link
Member Author

tony-go commented Jan 23, 2023

Thanks @aduh95 👋🏼

Let me know if it's good now ^^

@tony-go tony-go changed the title doc: fix commit message using test instead of deps tools,doc: fix commit message using test instead of deps Jan 23, 2023
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RaisinTen RaisinTen added tools Issues and PRs related to the tools directory. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 23, 2023
@RaisinTen RaisinTen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 23, 2023
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit e7504f2 into nodejs:main Jan 27, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in e7504f2

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
PR-URL: #46313
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
PR-URL: #46313
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
PR-URL: #46313
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
PR-URL: #46313
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants