Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: support describe / it only shorthands #46562

Closed
richiemccoll opened this issue Feb 8, 2023 · 0 comments · Fixed by #46604
Closed

test_runner: support describe / it only shorthands #46562

richiemccoll opened this issue Feb 8, 2023 · 0 comments · Fixed by #46604
Labels
feature request Issues that request new features to be added to Node.js. test_runner Issues and PRs related to the test runner subsystem.

Comments

@richiemccoll
Copy link
Contributor

richiemccoll commented Feb 8, 2023 •
edited
Loading

What is the problem this feature will solve?

A common shorthand when writing tests is to be able to quickly run isolated blocks of tests using describe.only and it.only.

Examples

Currently the test runner doesn't support these shorthands.

  • TypeError: describe.only is not a function
  • error: 'it.only is not a function'

What is the feature you are proposing to solve the problem?

Use a consistent approach with the other describe/it shorthands (skip and todo) and add another for only.

What alternatives have you considered?

No response
@richiemccoll richiemccoll added the feature request Issues that request new features to be added to Node.js. label Feb 8, 2023
@VoltrexKeyva VoltrexKeyva added the test_runner Issues and PRs related to the test runner subsystem. label Feb 8, 2023
@richiemccoll richiemccoll mentioned this issue Feb 10, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Feb 21, 2023
@richiemccoll
test_runner: add describe.only and it.only shorthands
0093fd3 
PR-URL: #46604
Fixes: #46562
Reviewed-By: Moshe Atlow <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this issue Feb 25, 2023
@richiemccoll @MoLow
test_runner: add describe.only and it.only shorthands
c0e13de 
PR-URL: nodejs#46604
Fixes: nodejs#46562
Reviewed-By: Moshe Atlow <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this issue Feb 25, 2023
@richiemccoll @MoLow
test_runner: add describe.only and it.only shorthands
c0887dc 
PR-URL: nodejs#46604
Fixes: nodejs#46562
Reviewed-By: Moshe Atlow <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this issue Feb 25, 2023
@richiemccoll @MoLow
test_runner: add describe.only and it.only shorthands
6ef4886 
PR-URL: nodejs#46604
Fixes: nodejs#46562
Reviewed-By: Moshe Atlow <[email protected]>
juanarbol pushed a commit that referenced this issue Mar 3, 2023
@richiemccoll @juanarbol
test_runner: add describe.only and it.only shorthands
bbe1f7d 
PR-URL: #46604
Backport-PR-URL: #46839
Fixes: #46562
Reviewed-By: Moshe Atlow <[email protected]>
juanarbol pushed a commit that referenced this issue Mar 5, 2023
@richiemccoll @juanarbol
test_runner: add describe.only and it.only shorthands
0a690ef 
PR-URL: #46604
Backport-PR-URL: #46839
Fixes: #46562
Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this issue Mar 13, 2023
@richiemccoll @targos
test_runner: add describe.only and it.only shorthands
aa41f27 
PR-URL: #46604
Fixes: #46562
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_runner: add describe.only and it.only shorthands richiemccoll/node
2 participants
@richiemccoll @VoltrexKeyva