v13.0.1 proposal #30081
Merged
v13.0.1 proposal #30081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #29962 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #29961 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #29961 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Provides some missing test coverage. PR-URL: #29970 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: #29973 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
PR-URL: #29950 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #29937 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Currently `--es-module-specifier-resolution=node` has an alternative resolution order than the default in common.js, this causes inconsistencies. As discussed in @nodejs/modules we want to preserve resolution order between implementations. PR-URL: #29974 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]>
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: #29995 Fixes: nodejs/build#1961 Refs: 53ca0b9#commitcomment-35494896 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Fixes: #29927 Refs: #29931 PR-URL: #29965 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #29984 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
common.skipIfInspectorEnabled() is only used once in all of the tests. The test is more clear (in my opinion, at least) without the abstraction so put the check directly in the test. Additionally, it honestly looks like an error (which is how I noticed it in the first place) and that someone mistyped the far more common skipIfInspectorDisabled(). PR-URL: #29993 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Request Python 3 with pyenv and ensure that python3 is used by Makefile to run Python scripts. PR-URL: #29451 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
For compatibility with OpenSSL 1.1.0 and 1.0.1 a series of initialization wrappers were being called, many deprecated, and many calling each other internally already. Compatibility is unnecessary in 12.x and later, which support only OpenSSL 1.1.1, and the multiple calls cause the configuration file to be loaded multiple times. Fixes: #29702 See: - https://mta.openssl.org/pipermail/openssl-users/2019-October/011303.html - https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_init_ssl.html - https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_init_crypto.html PR-URL: #29999 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
update collaborator email address PR-URL: #30007 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Explicitly open files with utf8 encoding, otherwise the system could use another encoding such as latin1 by default. PR-URL: #30023 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Building and testing Node.js with Visual Studio 2019 is now working as expected. Fallback to VS 2017 if VS 2019 was not found. Fixes: #27214 PR-URL: #30022 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
From V8 7.9, the option will no longer exist upstream. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1796325 PR-URL: #30021 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: #29996 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere. PR-URL: #30004 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #30029 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This test would be broken by V8 7.9 due to the changed `ArrayBuffer` backing store management (the same way that V8 7.8 broke this for `SharedArrayBuffer`s). While working on a solution, it would be good to already have this test in Node.js to avoid unnecessary accidental breakage. Refs: nodejs/node-v8#115 PR-URL: #30044 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Also eliminate some redundancy. PR-URL: #30038 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
`configure` will log a warning if the detected compiler is not new enough. Take some of the guesswork out of it by also logging the version of the compiler that was detected. PR-URL: #30028 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]>
Make ListNode<T> postmortem easier to find last items in the queue. PR-URL: #30027 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Fold `CancelPendingDelayedTasks()` into `UnregisterIsolate()` and make implementing it optional. It makes sense for these two operations to happen at the same time, so it is sufficient to provide a single operation instead of two separate ones. PR-URL: #30034 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Linter failures in the `test-doc` make target were not failing the build if the subsequent `doctools` test passed as its exit code wasn't being preserved. Make the `lint` target a dependency of `test-doc` so that it is outside of the `node_use_openssl` guard -- its own dependencies have their own guards where necessary and the targets that don't require an available node (e.g. the C++ linters) will be allowed to run. PR-URL: #30012 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This commit removes a few std::endl that could be replaced by '\n' as it does not look like the buffer needs to be flushed in these places. This is only done in error handling, and once when the report has been generated, so this is very minor but I thought I'd bring it up in case it was overlooked. PR-URL: #30003 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs-github-bot
added
build
This comment has been minimized.
This comment has been minimized.
|
CITGM: https://ci.nodejs.org/job/citgm-smoker/2073/ Gonna head to bed now... if someone else wants to push / sign the release before I can get to it in the morning please go for it. |
This was referenced Oct 23, 2019
gireeshpunathil
approved these changes
Oct 23, 2019
MylesBorins
force-pushed
the
v13.0.1-proposal
branch
from
b3b0137 to
160f5fb
Compare
|
Nit: |
gengjiawen
approved these changes
Oct 23, 2019
|
I'm taking it. |
targos
force-pushed
the
v13.0.1-proposal
branch
from
160f5fb to
bdc09c6
Compare
BethGriggs
approved these changes
Oct 23, 2019
cjihrig
approved these changes
Oct 23, 2019
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 23, 2019
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-10-23, Version 13.0.1 (Current), @targos
Notable Changes
--es-module-specifier-resolution=nodeto match that of the CommonJS loader (Myles Borins) #29974.
Commits
19a983c615] - build: make linter failures failtest-doctarget (Richard Lau) #3001213f3d6c680] - build: log the found compiler version if too old (Richard Lau) #30028a25d2fcf8b] - build: make configure --without-snapshot a no-op (Michaël Zasso) #30021e04d0584a5] - build: default Windows build to Visual Studio 2019 (Michaël Zasso) #30022ccf58835c7] - build: use python3 to build and test on Travis (Christian Clauss) #29451b92afcd90c] - build: fix version checks in configure.py (Michaël Zasso) #299652dc4da0d8b] - build: build benchmark addons like test addons (Richard Lau) #299952f36976594] - deps: npm: patch support for 13.x (Jordan Harband) #300799d332ab4ce] - deps: upgrade to libuv 1.33.1 (Colin Ihrig) #2999689b9115c4d] - doc: --enable-source-maps and prepareStackTrace are incompatible (Benjamin Coe) #3004635bffcdd9d] - doc: join parts of disrupt section in cli.md (vsemozhetbyt) #300380299767508] - doc: update collaborator email address (Minwoo Jung) #30007ff4f2999e6] - doc: fix tls version typo (akitsu-sanae) #2998462b4ca6e32] - doc: clarify readable.unshift null/EOF (Robert Nagy) #29950dc83ff9056] - doc: remove unused Markdown reference links (Nick Schonning) #29961d80ece68ac] - doc: re-enable passing remark-lint rule (Nick Schonning) #29961828e171107] - doc: add server header into the discarded list of http message.headers (Huachao Mao) #299629729c5da8a] - esm: modify resolution order for specifier flag (Myles Borins) #29974cfd45ebf94] - module: refactor modules bootstrap (Bradley Farias) #29937d561321e4a] - src: remove unnecessary std::endl usage (Daniel Bevenius) #30003ed80c233cd] - src: make implementing CancelPendingDelayedTasks for platform optional (Anna Henningsen) #300348fcc039de9] - src: expose ListNode<T>::prev_ on postmortem metadata (legendecas) #300270c88dc1932] - src: fewer uses of NODE_USE_V8_PLATFORM (Shelley Vohr) #30029972144073b] - src: remove unused iomanip include (Daniel Bevenius) #30004b019ccd59d] - src: initialize openssl only once (Sam Roberts) #299993eae670470] - src: refine maps parsing for large pages (Gabriel Schulhof) #29973f3712dfe83] - stream: simplify uint8ArrayToBuffer helper (Luigi Pinca) #3004146aa4810ad] - stream: remove dead code (Luigi Pinca) #30041f155dfeecb] - test: expand Worker test for non-shared ArrayBuffer (Anna Henningsen) #30044e110d81b17] - test: fix test runner for Python 3 on Windows (Michaël Zasso) #30023c096f251e4] - test: remove common.skipIfInspectorEnabled() (Rich Trott) #29993b1b8663a23] - test: add cb error test for fs.close() (Matteo Rossi) #29970