stream: remove dead code #30041

lpinca · 2019-10-20T05:31:40Z

String.prototype.split() returns an array of strings so the branch is
never taken.

Fixes: #30040

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: nodejs#30040

nodejs-github-bot · 2019-10-20T05:34:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26117/

addaleax

You can also remove the fallback code altogether, similar to #29514

The fallback code is no longer used when exporting to readable-stream. Refs: nodejs#29514

lpinca · 2019-10-20T11:39:49Z

@addaleax done, added as a separate commit here. I'll open a dedicated PR if needed/preferred.

nodejs-github-bot · 2019-10-20T12:30:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26120/

richardlau

Would like some confirmation from @nodejs/streams that this doesn't affect readable-stream.

addaleax · 2019-10-20T12:43:11Z

@richardlau #29475 (comment)

mcollina

LGTM

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Trott · 2019-10-22T18:38:27Z

Landed in 4201cdd...1070153

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

stream: remove dead code

71e86ab

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: nodejs#30040

nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Oct 20, 2019

ZYSzys approved these changes Oct 20, 2019

View reviewed changes

devnexen approved these changes Oct 20, 2019

View reviewed changes

addaleax approved these changes Oct 20, 2019

View reviewed changes

stream: simplify uint8ArrayToBuffer helper

3d144c1

The fallback code is no longer used when exporting to readable-stream. Refs: nodejs#29514

richardlau approved these changes Oct 20, 2019

View reviewed changes

cjihrig approved these changes Oct 20, 2019

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2019

gengjiawen approved these changes Oct 21, 2019

View reviewed changes

trivikr approved these changes Oct 21, 2019

View reviewed changes

mcollina approved these changes Oct 21, 2019

View reviewed changes

SimonSchick approved these changes Oct 21, 2019

View reviewed changes

Trott closed this Oct 22, 2019

lpinca deleted the gh-30040 branch October 22, 2019 18:56

MylesBorins mentioned this pull request Oct 23, 2019

v13.0.1 proposal #30081

Merged

targos mentioned this pull request Nov 10, 2019

v12.13.1 release proposal #30352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stream: remove dead code #30041

stream: remove dead code #30041

lpinca commented Oct 20, 2019 •

edited

Loading

nodejs-github-bot commented Oct 20, 2019

addaleax left a comment

lpinca commented Oct 20, 2019 •

edited

Loading

nodejs-github-bot commented Oct 20, 2019

richardlau left a comment

addaleax commented Oct 20, 2019

mcollina left a comment

Trott commented Oct 22, 2019

stream: remove dead code #30041

stream: remove dead code #30041

Conversation

lpinca commented Oct 20, 2019 • edited Loading

Checklist

nodejs-github-bot commented Oct 20, 2019

addaleax left a comment

Choose a reason for hiding this comment

lpinca commented Oct 20, 2019 • edited Loading

nodejs-github-bot commented Oct 20, 2019

richardlau left a comment

Choose a reason for hiding this comment

addaleax commented Oct 20, 2019

mcollina left a comment

Choose a reason for hiding this comment

Trott commented Oct 22, 2019

lpinca commented Oct 20, 2019 •

edited

Loading

lpinca commented Oct 20, 2019 •

edited

Loading