Weird dead code in `lib/stream.js` #30040

isaacs · 2019-10-20T04:43:07Z

Noticed this bit of code in lib/stream.js on the master branch:

const version = process.version.substr(1).split('.');
if (version[0] === 0 && version[1] < 12) {
  Stream._uint8ArrayToBuffer = Buffer;
} else {
  ...

Since the code internal in node can only ever be the version that it is, it seems odd to be checking the version in this way.
It looks like it's checking for node 0.x < 0.12??
Splitting a string returns an array of strings, so version[0] === 0 would always return false even in node 0.11 and before.

I think this can be removed?

Version: 12.12.0
Platform: All
Subsystem: stream

The text was updated successfully, but these errors were encountered:

lpinca · 2019-10-20T05:20:35Z

I think it was added for readable-stream but yeah it seems broken and readable-stream now requires Node.js >= 6.

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: nodejs#30040

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

lpinca added a commit to lpinca/node that referenced this issue Oct 20, 2019

stream: remove dead code

71e86ab

`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: nodejs#30040

lpinca mentioned this issue Oct 20, 2019

stream: remove dead code #30041

Closed

2 tasks

lpinca added the stream Issues and PRs related to the stream subsystem. label Oct 20, 2019

Trott closed this as completed in 94230d1 Oct 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weird dead code in `lib/stream.js` #30040

Weird dead code in `lib/stream.js` #30040

isaacs commented Oct 20, 2019

lpinca commented Oct 20, 2019 •

edited

Loading

Weird dead code in lib/stream.js #30040

Weird dead code in lib/stream.js #30040

Comments

isaacs commented Oct 20, 2019

lpinca commented Oct 20, 2019 • edited Loading

Weird dead code in `lib/stream.js` #30040

Weird dead code in `lib/stream.js` #30040

lpinca commented Oct 20, 2019 •

edited

Loading