Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node-daily-master always fails due to napi test in node-test-commit-custom-suite-freestyle #1961

Closed
AshCripps opened this issue Oct 16, 2019 · 2 comments · Fixed by nodejs/node#29995
Closed

Node-daily-master always fails due to napi test in node-test-commit-custom-suite-freestyle #1961

AshCripps opened this issue Oct 16, 2019 · 2 comments · Fixed by nodejs/node#29995

Comments

@AshCripps
Copy link
Member

https://ci.nodejs.org/job/node-daily-master/ is failing everyday, Error looks real and probably predictable.

Example below of a common failure:

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/9513/testReport/(root)/test/benchmark_test_benchmark_napi/

@nodejs/napi. any opinions?
@AshCripps AshCripps changed the title Node-daily-master always failure due to napi test in node-test-commit-custom-suite-freestyle Node-daily-master always fails due to napi test in node-test-commit-custom-suite-freestyle Oct 16, 2019
@richardlau
Copy link
Member

Related to nodejs/node@53ca0b9#commitcomment-35494896?

cc @nodejs/n-api

@richardlau richardlau mentioned this issue Oct 16, 2019
Merged
2 tasks
@richardlau
Copy link
Member

I've opened nodejs/node#29995 to fix the break.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Oct 22, 2019
build: build benchmark addons like test addons
4d29011 
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: nodejs#29995
Fixes: nodejs/build#1961
Refs: nodejs@53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@gabrielschulhof gabrielschulhof mentioned this issue Oct 22, 2019
Closed
2 tasks
MylesBorins pushed a commit to nodejs/node that referenced this issue Oct 23, 2019
@richardlau @MylesBorins
build: build benchmark addons like test addons
dfac2f8 
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this issue Oct 23, 2019
@richardlau @MylesBorins
build: build benchmark addons like test addons
2dc4da0 
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Nov 8, 2019
@richardlau @targos
build: build benchmark addons like test addons
9383e3b 
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Nov 10, 2019
@richardlau @targos
build: build benchmark addons like test addons
a1adce1 
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@codebytere codebytere mentioned this issue Aug 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richardlau @AshCripps