-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: npm: patch support for 13.x #30079
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
npm
Issues and PRs related to the npm client dependency or the npm registry.
label
Oct 23, 2019
Can we please fast track this? I can help prepare a v13.1.0 release asap to get the fix out. |
MylesBorins
changed the title
deps: npm: patch support for 13.0.0
deps: npm: patch support for 13.x
Oct 23, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: nodejs#30066
MylesBorins
force-pushed
the
fix-npm-13
branch
from
October 23, 2019 06:33
c121cfd
to
f8a689f
Compare
@MylesBorins v13.0.1 i hope |
(LGTM) |
targos
approved these changes
Oct 23, 2019
addaleax
approved these changes
Oct 23, 2019
landed in d8aa38c |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
PR for 13.0.1 opened #30081 |
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
npm
Issues and PRs related to the npm client dependency or the npm registry.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should keep the npm warning at bay until it is patched
upstream.
/cc @ljharb
Refs: npm/cli#269
Refs: #30066