Skip to content

fix(ci): target promotion PR for Claude review comments - #2576

Merged
serrrfirat merged 4 commits into
stagingfrom
fix/claude-review-comment-target
Apr 19, 2026
Merged

fix(ci): target promotion PR for Claude review comments#2576
serrrfirat merged 4 commits into
stagingfrom
fix/claude-review-comment-target

Conversation

@serrrfirat

@serrrfirat serrrfirat commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Next staging promotion cycle should have Claude review comments on the promotion PR, not on source PRs
  • Verify turn count drops (fewer permission denials)

🤖 Generated with Claude Code

@serrrfirat @claude
fix(ci): target promotion PR for Claude review comments
335ce69 
The Claude Code Review workflow runs on staging promotion PRs but the
agent was tracing changes back to original source PRs and posting
comments there (e.g. on already-merged #2539 instead of promotion
#2575). Fix by explicitly passing the promotion PR number in the prompt.

Also tell the agent which tools are available to avoid wasting turns
on permission denials (~24% of turns were denied tool calls).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gemini-code-assist

gemini-code-assist Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added scope: ci CI/CD workflows size: S 10-49 changed lines risk: medium Business logic, config, or moderate-risk modules contributor: core 20+ merged PRs labels Apr 17, 2026
@claude

claude Bot commented Apr 17, 2026

Copy link
Copy Markdown

Code review

Found 2 issues:

  1. [MEDIUM:75] Tool availability statement could be more explicit about restriction scope

    The instruction 'Your ONLY available tools are: Read, Glob, Grep, Agent, and Bash with gh/git commands' appears clear, but introducing this restriction for the first time in the prompt (previously only in allowedTools config) should be emphasized earlier in the agent instructions to prevent agents from attempting restricted Bash commands.

    https://github.com/anthropics/ironclaw/blob/27445aa/.github/workflows/claude-review.yml#L113-L115

  2. [LOW:65] Agent instructions lack explicit warning about tool restrictions

    When agents are instructed to 'read the PR diff with gh pr diff' (lines 64-83), they are not explicitly warned that other Bash commands like cat, cargo, python are unavailable. While the framework enforces this via allowedTools, adding a brief note in the agent instructions that they inherit the same tool restrictions would prevent wasted turns from denied tool calls.

    https://github.com/anthropics/ironclaw/blob/27445aa/.github/workflows/claude-review.yml#L64-L83

@serrrfirat @claude
fix: resolve CI failures — restore clippy allow, fix install-param ex…
705cae1 
…traction

- Restore `#[allow(clippy::too_many_arguments)]` on `register_startup_channels`
  that was accidentally removed
- Add `tool_install`/`tool_activate` parameter name extraction to
  `pending_gate_extension_name` fallback path (mirrors AuthManager logic)
  so extension name resolves correctly without auth_manager

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@serrrfirat serrrfirat added the skip-regression-check Bypass regression test CI gate (tests exist but not in tests/ dir) label Apr 17, 2026
@github-actions github-actions Bot added scope: channel/web Web gateway channel scope: channel/wasm WASM channel runtime labels Apr 17, 2026
@serrrfirat
serrrfirat merged commit 737029d into staging Apr 19, 2026
16 checks passed
@serrrfirat
serrrfirat deleted the fix/claude-review-comment-target branch April 19, 2026 17:42
This was referenced Apr 19, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 22, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ironclaw-ci ironclaw-ci Bot mentioned this pull request Apr 30, 2026
Closed
theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
@serrrfirat @claude
fix(ci): target promotion PR for Claude review comments (nearai#2576)
ab7fa68 
* fix(ci): target promotion PR for Claude review comments

The Claude Code Review workflow runs on staging promotion PRs but the
agent was tracing changes back to original source PRs and posting
comments there (e.g. on already-merged nearai#2539 instead of promotion
nearai#2575). Fix by explicitly passing the promotion PR number in the prompt.

Also tell the agent which tools are available to avoid wasting turns
on permission denials (~24% of turns were denied tool calls).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: resolve CI failures — restore clippy allow, fix install-param extraction

- Restore `#[allow(clippy::too_many_arguments)]` on `register_startup_channels`
  that was accidentally removed
- Add `tool_install`/`tool_activate` parameter name extraction to
  `pending_gate_extension_name` fallback path (mirrors AuthManager logic)
  so extension name resolves correctly without auth_manager

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: channel/wasm WASM channel runtime scope: channel/web Web gateway channel scope: ci CI/CD workflows size: S 10-49 changed lines skip-regression-check Bypass regression test CI gate (tests exist but not in tests/ dir)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@serrrfirat