Skip to content

chore: promote staging to staging-promote/4577d0e8-24675460727 (2026-04-20 16:04 UTC) - #2750

Merged
henrypark133 merged 1 commit into
mainfrom
staging-promote/392a33a4-24676887276
Apr 21, 2026
Merged

henrypark133 merged 1 commit into
mainfrom
staging-promote/392a33a4-24676887276

Conversation

@ironclaw-ci

@ironclaw-ci ironclaw-ci Bot commented Apr 20, 2026 •

Copy link
Copy Markdown
Contributor

Auto-promotion from staging CI

Batch range: 7fb41555a9e55677d1aaea29ca567a5b369c2b05..392a33a478af14a42766a077325539a2cb734cf8
Promotion branch: staging-promote/392a33a4-24676887276
Base: staging-promote/4577d0e8-24675460727
Triggered by: Staging CI batch at 2026-04-20 16:04 UTC

Commits in this batch (48):

Current commits in this promotion (1)

Current base: staging-promote/4577d0e8-24675460727
Current head: staging-promote/392a33a4-24676887276
Current range: origin/staging-promote/4577d0e8-24675460727..origin/staging-promote/392a33a4-24676887276

Auto-updated by staging promotion metadata workflow

Waiting for gates:

  • Tests: pending
  • E2E: pending
  • Claude Code review: pending (will post comments on this PR)

Auto-created by staging-ci workflow

Co-authored-by: Guille <gagdiez.c@gmail.com>
@github-actions github-actions Bot added scope: docs Documentation size: S 10-49 changed lines risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Apr 20, 2026
@claude

claude Bot commented Apr 20, 2026

Copy link
Copy Markdown

Code review

Found 3 issues:

  1. [HIGH:85] Race condition in test — pasted_multiline_input_submits_intact uses non-blocking try_recv() which can panic if the async message processing hasn't completed yet. The handle_event() call is awaited, but the message send may happen asynchronously within it, causing try_recv() to return None before the message arrives. Should use blocking recv() (in a spawned blocking task or with timeout).

    https://github.com/anthropics/ironclaw/blob/392a33a478af14a42766a077325539a2cb734cf8/crates/ironclaw_tui/src/app.rs#L3440-L3444

  2. [MEDIUM:75] Missing unit test coverage for key mappings — The PR adds Shift+Enter support for inserting newlines, but there's no corresponding unit test in src/input.rs that verifies map_key() correctly routes Shift+Enter to InputAction::InsertNewline in the normal (non-search, non-palette) input context. Per CLAUDE.md's "Test Through the Caller" rule, the input mapping function should have its own unit coverage alongside the integration test.

    https://github.com/anthropics/ironclaw/blob/392a33a478af14a42766a077325539a2cb734cf8/crates/ironclaw_tui/src/app.rs#L3412-L3444

  3. [MEDIUM:50] Incomplete state assertions in test — pasted_multiline_input_submits_intact doesn't verify state.input_line_count is updated correctly after pasting, while the similar test paste_with_cr_line_endings_becomes_multiline_input does check this invariant. Without this assertion, regressions to line count tracking could be missed.

    https://github.com/anthropics/ironclaw/blob/392a33a478af14a42766a077325539a2cb734cf8/crates/ironclaw_tui/src/app.rs#L3415-L3420

Base automatically changed from staging-promote/4577d0e8-24675460727 to main April 21, 2026 03:18
@henrypark133
henrypark133 merged commit 392a33a into main Apr 21, 2026
115 of 149 checks passed
@henrypark133
henrypark133 deleted the staging-promote/392a33a4-24676887276 branch April 21, 2026 03:18

This branch had an error being deployed

1 failed and 5 inactive deployments
Ironclaw-QA / production — 392a33a4 Deployed Apr 20, 2026 by railway-app[bot]
venice-ironclaw / production — 392a33a4 Deployed Apr 20, 2026 by railway-app[bot]
cosmose-ironclaw / production — 392a33a4 Deployed Apr 20, 2026 by railway-app[bot]
humble-cat / staging-cameron — 392a33a4 Deployed Apr 20, 2026 by railway-app[bot]
Near Foundation Ironclaw / production — 392a33a4 Deployed Apr 20, 2026 by railway-app[bot]
ironclaw-nearai / production — 392a33a4 Deployed Apr 20, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules scope: docs Documentation size: S 10-49 changed lines staging-promotion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants