chore: promote staging to staging-promote/65380170-24767546819 (2026-04-22 10:09 UTC) - #2848
Conversation
…2801) * docs(plan): update engine v2 architecture plan to reflect verified reality The plan doc claimed several items as missing/pending that are already implemented. Update to match ground truth so future readers don't redo the verification pass. Changes: - Compaction (§4.3): marked DONE, pointer to orchestrator/default.py:240-310 - Tool reliability (§4.9): tracker exists; integration tracked in #2800 PR-B - Routines/Jobs (§6.7): routine_to_mission_alias already translates routine_* calls; create_job aliasing tracked in #2800 PR-C - Two-phase commit (§6.7): marked IMPLEMENTED via unified gate (policy.rs:126-169 + structured.rs:139-171); simulate/preview intentionally not added at policy layer - Acceptance testing (§6.7): pointer to with_engine_v2 harness; coverage expansion tracked in #2800 PR-D - Phase 7: split into 7a (engine-side, DONE) and 7b (host cleanup, blocked on default flip) - Status header + Implementation Progress table: updated to match current state; default-flip work consolidated under issue #2800 No code changes. Refs: #2800 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(plan): address review feedback on engine v2 architecture plan Apply accuracy fixes from PR #2801 review: - Compaction threshold: describe as configurable via `compaction_threshold` (defaults to 85%), matching `compact_if_needed` in the Python orchestrator rather than claiming a fixed 85%. - Token estimation: move ownership to the Python orchestrator (which runs the chars/token heuristic); Rust no longer claims to own this. - Compaction cross-reference: drop the stale "crate-structure block above includes executor/compaction.rs" note — compaction lives entirely in Python. - Reliability injection details (`ENGINE_V2_RELIABILITY_HINTS` kill switch, `EffectBridgeAdapter` write-backs, `build_step_context` reads) are labelled as proposed PR-B follow-up work rather than described as verified reality. - Denylist phrasing: make it clear that `build_software` remains the only hard-denylisted v1 tool *after* PR-C lands, not before. - Provenance rules: document accurately that `ToolOutput` provenance only injects `RequireApproval` on `Financial` effects; `WriteExternal` taint comes only from `LlmGenerated`, per policy.rs:126-169. - Engine-side cleanup: acknowledge that `Session` / `Routine` identifiers still appear in engine docs/comments; the invariant is no runtime dependency, not zero string occurrences. No code changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
scope: docs
Code reviewFound 5 issues:
The PR claims "host-side cost population tracked in issue #2800 (PR-A)" as future work. However,
Section 4.3 claims "Compaction (from RLM) — IMPLEMENTED" and describes production-ready behavior. However,
The PR changes Phase 6 from "PARTIAL" to "DONE" while simultaneously listing "gate pause/resume, auth flows, mission execution, retrieval/learning flows, orchestrator-driven compaction" as pending coverage under issue #2800 (PR-D). These represent substantial unfinished work — the phase should remain PARTIAL or PR-D completion should be a prerequisite for the status change.
Section 4.9 describes
The PR claims "Two-phase commit — IMPLEMENTED via unified gate" and describes policy/executor behavior. However, the same section notes that acceptance test coverage for "gate pause/resume" is still pending (PR-D). The end-to-end flow from policy decision to user approval to action execution is not yet proven in tests, so the completion claim is premature. |
This branch had an error being deployed
2 participants
Auto-promotion from staging CI
Batch range:
7fb41555a9e55677d1aaea29ca567a5b369c2b05..417ee611df92cb1030fe60c514ba2ba31a081ba5Promotion branch:
staging-promote/417ee611-24772628357Base:
staging-promote/65380170-24767546819Triggered by: Staging CI batch at 2026-04-22 10:09 UTC
Commits in this batch (75):
onboardfails with "Failed to save settings to database", butironclawstarts successfully and applies migrations #846) (fix(setup): run migrations during onboard when DATABASE_URL preset (#846) #2309)Current commits in this promotion (1)
Current base:
staging-promote/65380170-24767546819Current head:
staging-promote/417ee611-24772628357Current range:
origin/staging-promote/65380170-24767546819..origin/staging-promote/417ee611-24772628357Auto-updated by staging promotion metadata workflow
Waiting for gates:
Auto-created by staging-ci workflow