Skip to content

chore: promote staging to staging-promote/1a44a944-24868089372 (2026-04-24 05:16 UTC) - #2933

Merged
henrypark133 merged 1 commit into
mainfrom
staging-promote/eb75a62a-24873527746
Apr 29, 2026
Merged

chore: promote staging to staging-promote/1a44a944-24868089372 (2026-04-24 05:16 UTC)#2933
henrypark133 merged 1 commit into
mainfrom
staging-promote/eb75a62a-24873527746

Conversation

@ironclaw-ci

@ironclaw-ci ironclaw-ci Bot commented Apr 24, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Auto-promotion from staging CI

Batch range: 7fb41555a9e55677d1aaea29ca567a5b369c2b05..eb75a62a97741933bf98b5d74c83f03e4cb1872f
Promotion branch: staging-promote/eb75a62a-24873527746
Base: staging-promote/1a44a944-24868089372
Triggered by: Staging CI batch at 2026-04-24 05:16 UTC

Commits in this batch (88):

Current commits in this promotion (1)

Current base: staging-promote/1a44a944-24868089372
Current head: staging-promote/eb75a62a-24873527746
Current range: origin/staging-promote/1a44a944-24868089372..origin/staging-promote/eb75a62a-24873527746

Auto-updated by staging promotion metadata workflow

Waiting for gates:

  • Tests: pending
  • E2E: pending
  • Claude Code review: pending (will post comments on this PR)

Auto-created by staging-ci workflow

@ilblackdragon @claude
feat(debug-panel): expand Activity tab coverage with CodeAct + warnin…
eb75a62 
…gs (#2850)

* feat(debug-panel): expand Activity tab coverage with CodeAct + warnings

The Activity tab was missing most event types: CodeAct runs showed only
lossy chat summaries, WARN/ERROR logs only landed in server stdout, and
tool entries hid their parameters on success.

- Emit AppEvent::CodeExecuted (verbose-only) with raw code, stdout, and
  return value from the engine orchestrator so observers see what the
  model actually wrote.
- Bridge WARN/ERROR tracing into AppEvent::Warning via
  spawn_warning_bridge, scoped by owner_id in multi-tenant mode to
  prevent cross-tenant log bleed.
- Backfill params_summary on ActionExecuted/ActionFailed events from
  structured + scripting executors so the Activity tab shows tool args
  immediately (not just on failure) without waiting for tool_completed.
- Wire debug-panel.js to render code_executed, warning, gate_required,
  gate_resolved, approval_needed, skill_activated, plan_update,
  thread_state_changed, child/mission_thread_spawned, onboarding_state,
  image_generated, suggestions, and the full sandbox-job event family.
- Extract shared on(name, handler) wrapper to dedupe ~25 copies of the
  JSON-parse + reconnect-counter housekeeping and keep lastEventTime
  bookkeeping consistent across listeners.
- Add i18n strings (en/ko/zh-CN) and CSS icon colors for the new
  activity types.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(debug-panel): address review feedback on activity-trace PR

- summarize_params generic fallback: skip sensitive-looking parameter
  keys (token/secret/password/api_key/auth/credential/bearer) so MCP
  and unknown-tool calls can't surface secret values into
  ActionExecuted events or debug-panel SSE. Adds two regression tests.
- Cap CodeExecuted code/stdout at 8_000 chars (tail-last) before
  emission so a step that prints a large blob can't bloat persisted
  thread events. Matches the existing scripting OUTPUT_TRUNCATE_LEN.
- await_thread_outcome: skip broadcasting verbose-only AppEvents when
  no debug subscriber is connected — mirrors the send_status gate
  and keeps CodeExecuted off the shared SSE broadcast buffer for
  normal browser tabs.
- spawn_warning_bridge: same short-circuit on has_verbose_receivers.
- debug-panel.js: introduce GATE_RESOLUTION_STATUS so `expired`
  (a failure path from router.rs) no longer renders as a green
  success badge; shared STATUS_TO_ACTIVITY map is kept for jobs/
  plans/onboarding where `success` is the right default.
- debug-panel.js: migrate the remaining legacy listeners to the
  shared on() wrapper so lastEventTime / totalEventsReceived
  bookkeeping stays consistent across every activity listener.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(debug-panel): address PR #2850 follow-up review on leak / tenant scoping

- Warning bridge (`src/channels/web/mod.rs`): disable entirely in
  multi-tenant mode. The `tracing` layer captures log context at the
  global subscriber scope, not at request scope, so scoping the bridge
  to the gateway `owner_id` misroutes tenant A's WARN/ERROR log lines
  to the admin account (and prevents tenant A from ever seeing them).
  Per-request provenance would need threading through every `warn!` /
  `error!` call site — out of scope for this PR — so the safe move is
  to keep the bridge off until that lands.
- `summarize_params` (`crates/ironclaw_engine/src/types/event.rs`):
  strip URL query strings / fragments / userinfo for `http` and
  `web_fetch`, and redact auth-bearing flag values (`-H`, `--header`,
  `-u`, `--user`, `--token`, `--api-key`, `--password`, `--auth`,
  `--bearer`) plus embedded URL query strings inside `shell` commands.
  Signed URLs, inline `Authorization: Bearer …` headers, and query-
  string API keys no longer reach `ToolCompleted.parameters` on the
  debug SSE stream. Six regression tests added.
- `CodeExecuted` redaction (`src/bridge/router.rs`): apply the leak
  detector to `code` / `stdout` / `return_value` at the bridge
  boundary before SSE broadcast. The engine crate has no dependency on
  `ironclaw_safety`, so scrubbing lives here. Adds
  `SafetyLayer::leak_detector()` and `EffectBridgeAdapter::safety()`
  accessors. Handles both `Redact` and `Block`-action matches
  (scan_and_clean's `redacted_content` is `None` for Block-only
  matches, which would have passed bearer tokens / API keys through
  unchanged). Regression test covers string and nested-JSON cases.

* fix(debug-panel): address PR #2850 Copilot follow-up review

- `src/channels/web/log_layer.rs`: annotate `spawn_warning_bridge`'s
  `sse.broadcast_for_user` / `sse.broadcast` sites with
  `// projection-exempt: log source, WARN/ERROR tracing bridge →
  AppEvent::Warning` so the PROJECTION safety check (#9 in
  `scripts/pre-commit-safety.sh`) recognises the tracing
  `LogBroadcaster` as a typed source log. Added a comment block
  explaining why the source-log category isn't yet in
  `.claude/rules/gateway-events.md`'s table.
- `crates/ironclaw_engine/src/executor/orchestrator.rs`: replace
  `tail_chars` (O(n) via `chars().count()`) with a local
  `tail_utf8_bytes` helper for the `CodeExecuted` emission path. Byte
  based so it stays O(1) + ≤3-byte UTF-8 boundary walk for arbitrarily
  large `code`/`stdout`. Also add `bounded_return_value` so a CodeAct
  snippet returning a 50 MB JSON value doesn't bloat persisted thread
  events — strings are tail-truncated; structured values that
  serialize past 8 KiB are dropped to `None` (rather than truncated
  into unparseable JSON). Seven regression tests cover ASCII / emoji
  boundary / null / small struct / oversized struct / large-string
  paths.

`tail_chars` is kept unchanged for its existing callers, whose inputs
are already bounded (`OUTPUT_TRUNCATE_LEN`, 500-char error slices).

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added scope: channel/web Web gateway channel size: XL 500+ changed lines risk: medium Business logic, config, or moderate-risk modules contributor: core 20+ merged PRs labels Apr 24, 2026
@claude

claude Bot commented Apr 24, 2026

Copy link
Copy Markdown

Code review

Found 7 issues:

  1. [MEDIUM:HIGH] Regex pattern logic error in shell command redaction

    • redact_shell_command_for_display() uses character class [^"']* which stops at the opposite quote type inside values
    • Example: -H "It's-a-token" fails because the pattern expects a closing double-quote but hits the single quote first
    • Should use a more robust pattern or atomic grouping to handle values containing mixed quotes

    https://github.com/anthropics/ironclaw/blob/eb75a62a97741933bf98b5d74c83f03e4cb1872f/crates/ironclaw_engine/src/types/event.rs#L463

  2. [MEDIUM:HIGH] Violation of CLAUDE.md: .unwrap() on regex compilation in production code

    • Lines 141, 146, 152, 155 use .unwrap() on Regex::new() despite hardcoded literals
    • CLAUDE.md explicitly forbids .unwrap() / .expect() in production code (tests are fine)
    • Comments justify it as safe, but the violation remains. Use expect("hardcoded literal") with message instead

    https://github.com/anthropics/ironclaw/blob/eb75a62a97741933bf98b5d74c83f03e4cb1872f/crates/ironclaw_engine/src/types/event.rs#L141-L155

  3. [HIGH:HIGH] Gateway Events Rule violation: AppEvent::Warning lacks durable source log

    • AppEvent::Warning is broadcast directly from tracing events with no persistent backing
    • On SSE reconnect, CodeExecuted events replay from engine persistence, but Warning events evaporate
    • The code acknowledges this with // projection-exempt: comments but doesn't follow the rule's guidance to migrate new source types into the canonical table
    • Per .claude/rules/gateway-events.md: file an issue to migrate Warning into the canonical source-log table rather than leaving it as ad-hoc SSE source

    https://github.com/anthropics/ironclaw/blob/eb75a62a97741933bf98b5d74c83f03e4cb1872f/src/channels/web/log_layer.rs#L340

  4. [MEDIUM:HIGH] Multi-tenant security boundary not architecturally enforced

    • The multi-tenant mode check in mod.rs:671–684 is a runtime if statement, not a compile-time constraint
    • Future refactors could accidentally re-enable the warning bridge in multi-tenant mode without realizing the tenant-isolation risk
    • Better: Make spawn_warning_bridge() accept multi_tenant_mode: bool and return Result, so the constraint is explicit and testable

    https://github.com/anthropics/ironclaw/blob/eb75a62a97741933bf98b5d74c83f03e4cb1872f/src/channels/web/mod.rs#L671-L684

  5. [MEDIUM:80] Unnecessary string allocation in tail_utf8_bytes() for non-truncated paths

    • Unconditional s.to_owned() even when s.len() <= max_bytes
    • Every code execution step calls this 3× (code, stdout, return_value), allocating even when no truncation occurs
    • Consider: if s.len() <= max_bytes { return s.to_string() } → could use Cow<str> or avoid cloning in the common case

    https://github.com/anthropic/ironclaw/blob/eb75a62a97741933bf98b5d74c83f03e4cb1872f/crates/ironclaw_engine/src/executor/orchestrator.rs#L2440

  6. [MEDIUM:70] Unbounded recursion risk in redact_secrets_in_json()

    • No depth guard on recursive JSON walk
    • Pathologically nested JSON (100+ levels) will overflow the stack
    • Return value is capped at 8KB but internal nesting depth is unbounded
    • Add a depth parameter with max limit (e.g., max depth 50)

    https://github.com/anthropics/ironclaw/blob/eb75a62a97741933bf98b5d74c83f03e4cb1872f/src/bridge/router.rs#L4682-L4699

  7. [LOW:HIGH] Test coverage gap per .claude/rules/testing.md

    • spawn_warning_bridge() has no caller-level integration test
    • The rule requires: when a helper gates a side effect (SSE broadcast triggered by log lines) with intermediate wrappers, test the full call chain, not just the helper
    • Add integration test: emit WARN/ERROR log, verify corresponding AppEvent::Warning appears on SSE for verbose subscribers only

    https://github.com/anthropics/ironclaw/blob/eb75a62a97741933bf98b5d74c83f03e4cb1872f/src/channels/web/log_layer.rs#L313-L361

Positive findings:

  • ✓ UTF-8 truncation implementation is correct with proper boundary validation
  • ✓ Multi-tenant log leakage correctly identified and disabled (runtime gate is good, architecture enforcement suggested above)
  • ✓ Secrets redaction at SSE boundary is comprehensive and well-tested
  • ✓ Verbose-only event gating prevents buffer floods for non-debug clients
  • ✓ Async broadcast loop lag recovery is correct

Base automatically changed from staging-promote/1a44a944-24868089372 to main April 29, 2026 04:09
@henrypark133
henrypark133 merged commit eb75a62 into main Apr 29, 2026
164 of 236 checks passed
@henrypark133
henrypark133 deleted the staging-promote/eb75a62a-24873527746 branch April 29, 2026 04:09

This branch had an error being deployed

2 failed and 4 inactive deployments
venice-ironclaw / production — eb75a62a Deployed Apr 24, 2026 by railway-app[bot]
View deployment
cosmose-ironclaw / production — eb75a62a Deployed Apr 24, 2026 by railway-app[bot]
View deployment
Ironclaw-QA / production — eb75a62a Deployed Apr 24, 2026 by railway-app[bot]
View deployment
humble-cat / staging-cameron — eb75a62a Deployed Apr 24, 2026 by railway-app[bot]
View deployment
Near Foundation Ironclaw / production — eb75a62a Deployed Apr 24, 2026 by railway-app[bot]
View deployment
ironclaw-nearai / production — eb75a62a Deployed Apr 24, 2026 by railway-app[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: channel/web Web gateway channel size: XL 500+ changed lines staging-promotion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henrypark133 @ilblackdragon