Skip to content

chore: promote staging to staging-promote/e7d9922c-25016769392 (2026-04-27 20:55 UTC) - #3000

Merged
henrypark133 merged 2 commits into
mainfrom
staging-promote/91c4c7ca-25018206332
Apr 29, 2026
Merged

chore: promote staging to staging-promote/e7d9922c-25016769392 (2026-04-27 20:55 UTC)#3000
henrypark133 merged 2 commits into
mainfrom
staging-promote/91c4c7ca-25018206332

Conversation

@ironclaw-ci

@ironclaw-ci ironclaw-ci Bot commented Apr 27, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Auto-promotion from staging CI

Batch range: 7fb41555a9e55677d1aaea29ca567a5b369c2b05..91c4c7ca7b34f75dd5dcc6273ef42de2ac670d54
Promotion branch: staging-promote/91c4c7ca-25018206332
Base: staging-promote/e7d9922c-25016769392
Triggered by: Staging CI batch at 2026-04-27 20:55 UTC

Commits in this batch (97):

Current commits in this promotion (2)

Current base: staging-promote/e7d9922c-25016769392
Current head: staging-promote/91c4c7ca-25018206332
Current range: origin/staging-promote/e7d9922c-25016769392..origin/staging-promote/91c4c7ca-25018206332

Auto-updated by staging promotion metadata workflow

Waiting for gates:

  • Tests: pending
  • E2E: pending
  • Claude Code review: pending (will post comments on this PR)

Auto-created by staging-ci workflow

serrrfirat and others added 2 commits April 27, 2026 23:06
@serrrfirat
docs(reborn): contract freeze review packet (#2983)
56613ee 
* docs(reborn): add contract freeze packet

* docs(reborn): clarify implementation status in review packet

* docs(reborn): clarify implementation status labels

* docs(reborn): distinguish backend support from capabilities

* docs(reborn): address contract review scope gaps

* docs(reborn): sync contract updates with implementation

* docs(reborn): clarify cutover dependency graph

* docs(reborn): define kernel loop boundary

* docs(reborn): refresh architecture map

* docs(reborn): add product manager architecture guide

* docs(reborn): diagram product manager guide
@henrypark133
fix: resolve v2 tool_info action inventory lookup (#2994)
91c4c7c
@github-actions github-actions Bot added scope: docs Documentation size: L 200-499 changed lines risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Apr 27, 2026
@claude

claude Bot commented Apr 27, 2026

Copy link
Copy Markdown

Code review

Found 5 issues:

  1. [MEDIUM:HIGH] Stringly-typed detail parameter in tool_info — Both scripting.rs (line 2202-2216) and structured.rs (line 1428-1443) check detail parameter with raw string equality (== Some("schema")). Per .claude/rules/types.md, fixed small sets should use enums, not string comparisons. A ToolInfoDetail enum (variants Schema | Summary) would prevent bugs and allow extending the parameter space.

    https://github.com/anthropics/ironclaw/blob/1543afd942866cc618cb1dda2bf9b62d02759807/crates/ironclaw_engine/src/executor/scripting.rs#L2202-L2216

    https://github.com/anthropics/ironclaw/blob/1543afd942866cc618cb1dda2bf9b62d02759807/crates/ironclaw_engine/src/executor/structured.rs#L1428-L1443

  2. [MEDIUM:HIGH] Hardcoded domain-specific summary in tool_info response — Test fixtures hardcode "always_required": ["name", "goal", "cadence"] as the summary for mission_create (e.g., structured.rs lines 1476-1483). Per the architecture, ActionDef has an optional discovery field designed to carry curated summaries. The response should use action.discovery.summary when present, not magic string literals. Test code that invents domain-specific values will diverge from production.

    https://github.com/anthropics/ironclaw/blob/1543afd942866cc618cb1dda2bf9b62d02759807/crates/ironclaw_engine/src/executor/structured.rs#L1476-L1483

  3. [MEDIUM:65] Mission documentation removal without fallback — The removal of detailed mission_create parameters from codeact_preamble.md is correct (tools should use tool_info for schemas). However, the schema returned via detail="schema" (lines 256-262 in scripting.rs) is minimal — just name, goal, cadence as required. It does not document the cadence format options ("event:telegram:.*", "0 9 * * *"), timezone defaults, or cooldown semantics. The LLM must now call tool_info first and infer the format from schema alone, adding a round-trip and risking misuse.

    https://github.com/anthropics/ironclaw/blob/1543afd942866cc618cb1dda2bf9b62d02759807/crates/ironclaw_engine/prompts/codeact_preamble.md#L36-L37

  4. [LOW:MEDIUM] Inconsistent error reporting across execution tiers — scripting.rs (line 2218) returns {"error": "missing inventory snapshot"} but structured.rs returns {"error": format!("missing_action:{requested}")}. Both should use consistent error shapes and message formats for debugging clarity.

    https://github.com/anthropics/ironclaw/blob/1543afd942866cc618cb1dda2bf9b62d02759807/crates/ironclaw_engine/src/executor/scripting.rs#L2218

  5. [MEDIUM:HIGH] Chaining both inline and discoverable actions — structured.rs (line 1425) now searches both inline and discoverable with .chain(), which is correct. However, this differs from the scripting.rs code path (line 2206) which searches only discoverable. This inconsistency means tool_info may return different results for the same tool depending on execution tier. Verify that both inline and discoverable tools should be discoverable at both tiers.

    https://github.com/anthropics/ironclaw/blob/1543afd942866cc618cb1dda2bf9b62d02759807/crates/ironclaw_engine/src/executor/structured.rs#L1425

🤖 Generated with Claude Code

Base automatically changed from staging-promote/e7d9922c-25016769392 to main April 29, 2026 04:09
@henrypark133
henrypark133 merged commit 91c4c7c into main Apr 29, 2026
83 of 94 checks passed
@henrypark133
henrypark133 deleted the staging-promote/91c4c7ca-25018206332 branch April 29, 2026 04:09

This branch had an error being deployed

1 failed and 5 inactive deployments
Ironclaw-QA / production — 91c4c7ca Deployed Apr 27, 2026 by railway-app[bot]
View deployment
humble-cat / staging-cameron — 91c4c7ca Deployed Apr 27, 2026 by railway-app[bot]
View deployment
ironclaw-nearai / production — 91c4c7ca Deployed Apr 27, 2026 by railway-app[bot]
View deployment
venice-ironclaw / production — 91c4c7ca Deployed Apr 27, 2026 by railway-app[bot]
View deployment
cosmose-ironclaw / production — 91c4c7ca Deployed Apr 27, 2026 by railway-app[bot]
View deployment
Near Foundation Ironclaw / production — 91c4c7ca Deployed Apr 27, 2026 by railway-app[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules scope: docs Documentation size: L 200-499 changed lines staging-promotion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henrypark133 @serrrfirat