osal Integration candidate: 2021-02-02 #774

astrogeco · 2021-02-04T15:29:09Z

Describe the contribution
Fix #742, make sure all pointers are checked for null
Fix #742, remove null checks from internal methods.
Fix #602, bring OSAL code coverage back up to 100%
Fix #765, add null pointer check.
Fix #771, Add workflow timeout and format check
Fix #777, Static allocation of DummyVec in OSC_INUM_TO_IVEC stub
Fix #783, Initialize locals flagged in static analysis
Fix #785, Clean commented out code
Fix #788, Resolve coercion alters value warnings
Fix #790, Return status from OS_ConsoleAPI_Init
Fix #797, Update os-impl-no-symtab.c to match APIs
Fix #793, Remove unreachable code in OS_SocketOpen_Impl for BSD socket
Fix #781, Terminate UT macro variadic lists
Fix #803, Add check of semaphore to avoid unreachable code in posix
Fix #808, length-limited string length checks
Fix #809, cast args to printf in queue-test
Fix #775, Add CodeQL analysis to workflow
Fix #805, Null terminate when using strncpy
Fix #769, Apply standard formatting

Testing performed
See https://github.com/nasa/cFS/pull/182/checks

Expected behavior changes

PR #768 - Adds test cases for OS_ObjectIdFinalizeDelete, OS_DeleteAllObjects, and others to get 100% line and function coverage on VxWorks and shared/portable layers.

PR #766 - Ensures APIs check for NULL inputs or have documentation stating that a null value is allowed.

PR #772 - Adds timeout to static analysis check and adds format check. Removes old .travis.yml and updates badges in readme.

PR #776 - Adds Code QL analysis on push to main and pull requests (to main)

PR #786 - Cleans commented-out code in tests to address static analysis warnings

PR #784 - Initializes local variables to avoid returning uninitialized values from stubs and address static-analysis findings

PR #789 - Replaces two local return codes defined as uint32 with int32 to resolve static-analysis warnings

PR #802 - Simplifies switch statements based on previous checks. Removes unreachable, dead code to resolve static-analysis warnings

PR #782 - Terminates unit test macros variadic lists with NULL to address CWE-121 CodeQL warning

PR #804 - Adds a check to send the semaphore to avoid unreachable code

PR #792 - Adds a status return to OS_ConsoleAPI_Init so debug warnings will get reported correctly on errors.

PR #778 - Declares DummyVec as static to avoid warning and returning stack allocated memory when returning VecTbl in OSC_INUM_TO_IVEC stub

PR #801 - Updates types in os-impl-no-symtab.c to match latest APIs

PR #800 - Updates types in os-impl-no-symtab.c to match latest APIs

PR #807 - Fixes missing NULL terminations and applies the standard "sizeof" pattern where appropriate. No longer truncates filename in OS_ModuleInfo.

PR #811 - Fixes %u conversion in RTEMS so to address build warning

PR #810 - Create a wrapper around memchr() that mimics the non-C99 function strnlen() defined in POSIX-2008. Use this instead of `strlen()`` whenever the string being checked either originates in or will be copied into a fixed-length array buffer. No behavior changes except if a bug causes strings to be unterminated.

PR #773 - No behavior change, applies the standard formatting using clang-format

System(s) tested on
Ubuntu 18.04

Additional context
Part of nasa/cFS#182

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@jphickey
@zanzaben

Adds test cases where necessary to get 100% line coverage on VxWorks impl + shared/portable layers.

Fix #602, bring OSAL code coverage back up to 100%

Fix #742, make sure all pointers are checked for null

astrogeco · 2021-02-04T15:29:28Z

Fix "pulls" in readme so PR links work

…S_BinSemCreate_Impl

Create a wrapper around memchr() that mimics the non-C99 function "strnlen()" which is in POSIX-2008. Use this instead of strlen() whenever the string being checked either originates in or will be copied into a fixed-length array buffer.

Using %u conversion requires unsigned int arg, not necessarily uint32

Fix #771, Add workflow timeout and format check

Fix #775, Add CodeQL analysis to workflow

Fix #785, Clean commented out code

Fix #783, Initialize locals flagged in static analysis

Fix #788, Resolve coercion alters value warnings

Fix #793, Remove unreachable code in OS_SocketOpen_Impl for BSD socket

Fix #781, Terminate UT macro variadic lists

Fix #803, Add check of semaphore to avoid unreachable code in posix OS_BinSemCreate_Impl

Fix #790, Return status from OS_ConsoleAPI_Init

Fix #777, Static allocation of DummyVec in OSC_INUM_TO_IVEC stub

Fix #797, Update os-impl-no-symtab.c to match APIs

Fix #796, Update os-impl-no-sockets.c to match APIs

Fix #805, Null terminate when using strncpy

Fix #809, cast args to printf in queue-test

Fix #808, length-limited string length checks

Fix #769, Apply standard formatting

Combines - nasa/cFE#1150 - nasa/osal#774 - nasa/PSP#250 - nasa/to_lab#84 - nasa/tblCRCTool#35

Combines nasa/cFE#1150 nasa/osal#774 nasa/PSP#250 nasa/to_lab#84 nasa/tblCRCTool#35

Combines nasa/cFE#1150 nasa/osal#774 nasa/PSP#250 nasa/to_lab#84 nasa/tblCRCTool#35 Also adds minor white-space fix in codeql-build.yml

Report an error if no files are available to fulfill an include file requirement, rather than leaving an empty file.

zanzaben and others added 7 commits January 20, 2021 13:03

Fix #742, make sure all pointers are checked for null

abebf1c

Fix #742, remove null checks from internal methods.

4a77997

Fix #602, bring OSAL code coverage back up to 100%

e77e657

Adds test cases where necessary to get 100% line coverage on VxWorks impl + shared/portable layers.

Fix #765, add null pointer check.

3b2c729

Fix #771, Add workflow timeout and format check

72da4f2

Merge pull request #768 from jphickey/fix-602-codecoverage

1ebb788

Fix #602, bring OSAL code coverage back up to 100%

Merge pull request #766 from zanzaben/fix742_null_pointer_cleanup

6787dfe

Fix #742, make sure all pointers are checked for null

skliper and others added 22 commits February 9, 2021 10:17

Fix #777, Static allocation of DummyVec in OSC_INUM_TO_IVEC stub

a51fc93

Fix #783, Initialize locals flagged in static analysis

b9a7697

Fix #785, Clean commented out code

58006ae

Fix #788, Resolve coercion alters value warnings

dd2368d

Fix #790, Return status from OS_ConsoleAPI_Init

44e0afc

Fix #796, Update os-impl-no-sockets.c to match APIs

0e76b63

Fix #797, Update os-impl-no-symtab.c to match APIs

721e042

Fix #793, Remove unreachable code in OS_SocketOpen_Impl for BSD socket

15ab294

Fix #781, Terminate UT macro variadic lists

8c83486

Fix #803, Add check of semaphore to avoid unreachable code in posix O…

6900275

…S_BinSemCreate_Impl

Fix #808, length-limited string length checks

efa1844

Create a wrapper around memchr() that mimics the non-C99 function "strnlen()" which is in POSIX-2008. Use this instead of strlen() whenever the string being checked either originates in or will be copied into a fixed-length array buffer.

Fix #809, cast args to printf in queue-test

6173a57

Using %u conversion requires unsigned int arg, not necessarily uint32

Fix #775, Add CodeQL analysis to workflow

66b48f6

Merge pull request #772 from skliper/fix771-workflow_updates

6e43c8e

Fix #771, Add workflow timeout and format check

Merge pull request #776 from skliper/fix775-add_codeql

3577bbc

Fix #775, Add CodeQL analysis to workflow

Merge pull request #786 from skliper/fix785-rm_commented_out_code

e964f1e

Fix #785, Clean commented out code

Merge pull request #784 from skliper/fix783-uninit_locals

eab4422

Fix #783, Initialize locals flagged in static analysis

Merge pull request #789 from skliper/fix788-coercion_alters_value

e882996

Fix #788, Resolve coercion alters value warnings

Merge pull request #802 from skliper/fix793-socket-dead-code

c878647

Fix #793, Remove unreachable code in OS_SocketOpen_Impl for BSD socket

Merge pull request #782 from skliper/fix781-terminate_va_list

f7c6d85

Fix #781, Terminate UT macro variadic lists

Merge pull request #804 from skliper/fix803-unreachable_binsemcreate

f237243

Fix #803, Add check of semaphore to avoid unreachable code in posix OS_BinSemCreate_Impl

Merge pull request #792 from skliper/fix790_os_consoleapi_init_rtn

7448a5e

Fix #790, Return status from OS_ConsoleAPI_Init

astrogeco and others added 5 commits February 12, 2021 15:44

Merge pull request #778 from skliper/fix777-inum_to_ivec

68d0e7f

Fix #777, Static allocation of DummyVec in OSC_INUM_TO_IVEC stub

Merge pull request #801 from skliper/fix797-no_symtab

a966ca7

Fix #797, Update os-impl-no-symtab.c to match APIs

Merge pull request #800 from skliper/fix796-no_sockets

920fde8

Fix #796, Update os-impl-no-sockets.c to match APIs

Fix #805, Null terminate when using strncpy

a8e0955

Merge pull request #800 from skliper/fix796-no_sockets

c24982d

Fix #796, Update os-impl-no-sockets.c to match APIs

astrogeco force-pushed the integration-candidate branch from 920fde8 to c24982d Compare February 12, 2021 21:25

astrogeco added the IC:2021-02-02 label Feb 12, 2021

astrogeco added 3 commits February 12, 2021 16:31

Merge pull request #807 from skliper/fix805-null_termination

a97e4f9

Fix #805, Null terminate when using strncpy

Merge pull request #811 from jphickey/fix-809-printf-format

9888e3f

Fix #809, cast args to printf in queue-test

Merge pull request #810 from jphickey/fix-808-strnlen

842fe88

Fix #808, length-limited string length checks

astrogeco marked this pull request as ready for review February 12, 2021 22:08

skliper and others added 3 commits February 12, 2021 18:08

Fix #796, Apply formatting

831100a

Merge pull request #773 from skliper/fix769-apply_formatting

28e60f3

Fix #769, Apply standard formatting

Bump to v5.1.0-rc1+dev262

fec2d91

astrogeco force-pushed the main branch from 2e482ff to 09a2c5e Compare February 12, 2021 23:39

astrogeco merged commit ff4f523 into main Feb 12, 2021

astrogeco mentioned this pull request Feb 16, 2021

cFS Bundle Integration Candidate: 2021-02-02 nasa/cFS#182

Merged

astrogeco added a commit to nasa/cFS that referenced this pull request Feb 16, 2021

Integration Candidate 2021-02-02

aceffb3

Combines - nasa/cFE#1150 - nasa/osal#774 - nasa/PSP#250 - nasa/to_lab#84 - nasa/tblCRCTool#35

astrogeco added a commit to nasa/cFS that referenced this pull request Feb 16, 2021

Integration Candidate 2021-02-02

2295806

Combines - nasa/cFE#1150 - nasa/osal#774 - nasa/PSP#250 - nasa/to_lab#84 - nasa/tblCRCTool#35

astrogeco added a commit to nasa/cFS that referenced this pull request Feb 16, 2021

Integration Candidate 2021-02-02

3ad1759

Combines nasa/cFE#1150 nasa/osal#774 nasa/PSP#250 nasa/to_lab#84 nasa/tblCRCTool#35

astrogeco added a commit to nasa/cFS that referenced this pull request Feb 16, 2021

Integration Candidate 2021-02-02

a41549c

Combines nasa/cFE#1150 nasa/osal#774 nasa/PSP#250 nasa/to_lab#84 nasa/tblCRCTool#35 Also adds minor white-space fix in codeql-build.yml

skliper added this to the 6.0.0 milestone Sep 24, 2021

jphickey added a commit to jphickey/osal that referenced this pull request Aug 10, 2022

Fix nasa#774, trigger error if no include files found

187adb2

Report an error if no files are available to fulfill an include file requirement, rather than leaving an empty file.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

osal Integration candidate: 2021-02-02 #774

osal Integration candidate: 2021-02-02 #774

astrogeco commented Feb 4, 2021 •

edited

Loading

astrogeco commented Feb 4, 2021

osal Integration candidate: 2021-02-02 #774

osal Integration candidate: 2021-02-02 #774

Conversation

astrogeco commented Feb 4, 2021 • edited Loading

astrogeco commented Feb 4, 2021

astrogeco commented Feb 4, 2021 •

edited

Loading