Fix #793, Remove unreachable code in OS_SocketOpen_Impl for BSD socket #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
I'm a little reluctant on this one - a switch() with an empty default case is a common paradigm where code is anticipated to be extended in the future.
Is this saying that the tool sees an empty default case as unreachable code?
Although I agree this doesn't change current behavior - it does make it more likely that the next time someone updates this it gets broken - the switch was there for future proofing.
|
Yeah, unreachable case. I get the future proof... but I'd prefer to add that back in if/when needed. Unless we can refactor to avoid dead code. In my book dead code avoidance trumps "default case for all switches". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #793, Just simplifies switch statements based on previous checks. Can always be expanded again if additional cases are implemented.
Testing performed
Build and execute unit tests, passed
Expected behavior changes
No impact to behavior
System(s) tested on
Additional context
Static analysis warning fix
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC