Return code not passed back in OS_ConsoleAPI_Init - static analysis warning

[skliper]

Is your feature request related to a problem? Please describe.
OS_ConsoleAPI_Init always returns success, but could error. Inconsistently implemented (if return_code is being recorded, return it... if it isn't needed why set it?)

Describe the solution you'd like
Either don't have a return value, or return the actual status. In test/coverage the expected return value should be confirmed.

Describe alternatives you've considered
None

Additional context
Static analysis warning since return_code is unused

Requester Info
Jacob Hageman - NASA/GSFC

[skliper]

Note the return code is checked and reported, just would have never reported the error:

osal/src/os/shared/src/osapi-common.c

Lines 175 to 183 in 09a2c5e

	case OS_OBJECT_TYPE_OS_CONSOLE:
	return_code = OS_ConsoleAPI_Init();
	break;
	default:
	break;
	}
	if (return_code != OS_SUCCESS)
	{
	OS_DEBUG("ID type 0x%x shared layer failed to initialize: %d\n", (unsigned int)idtype, (int)return_code);