Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub API's for null pointer checks #742

Closed
skliper opened this issue Jan 6, 2021 · 1 comment · Fixed by #766 or #774
Closed

Scrub API's for null pointer checks #742

skliper opened this issue Jan 6, 2021 · 1 comment · Fixed by #766 or #774
Assignees
@zanzaben
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Jan 6, 2021

Is your feature request related to a problem? Please describe.
All pointers should be checked for NULL prior to accessing, a few cases where this was observed have been fixed but need to do a complete scrub.

Describe the solution you'd like
Scrub and add any missing null pointer checks

Describe alternatives you've considered
None

Additional context
Use the new macros...

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 6.0.0 milestone Jan 6, 2021
@skliper
Copy link
Contributor Author

skliper commented Jan 6, 2021

Any other error checks (size != 0 or whatever) that make sense should also be added.

@zanzaben zanzaben mentioned this issue Jan 20, 2021
Closed
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 20, 2021
@zanzaben
Fix nasa#742, make sure all pointers are checked for null
abebf1c
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 21, 2021
@zanzaben
Fix nasa#742, remove null checks from internal methods.
a375c4c
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 22, 2021
@zanzaben
Fix nasa#742, remove null checks from internal methods.
a16e146
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 22, 2021
@zanzaben
Fix nasa#742, remove null checks from internal methods.
4a77997
@zanzaben zanzaben mentioned this issue Jan 22, 2021
Merged
astrogeco added a commit that referenced this issue Feb 3, 2021
@astrogeco
Merge pull request #766 from zanzaben/fix742_null_pointer_cleanup
6787dfe 
Fix #742, make sure all pointers are checked for null
@astrogeco astrogeco mentioned this issue Feb 12, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@JandlynBentley-at-NASA
Fix nasa#604, Added cFE User's Guide Reference to README.md (nasa#742)
5903b84 
* Fix nasa#604, Add a reference to cFE User's Guide to cFE README.md

This reference was placed toward the top of the document, before the Version History section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@zanzaben @skliper