Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os-impl-no-sockets.c out of date #796

Closed
skliper opened this issue Feb 10, 2021 · 0 comments · Fixed by #800
Closed

os-impl-no-sockets.c out of date #796

skliper opened this issue Feb 10, 2021 · 0 comments · Fixed by #800
Assignees
@skliper
Labels
bug public-api
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Feb 10, 2021 •
edited
Loading

Describe the bug
Conflicting types for the implementations

To Reproduce
Attempt to compile w/ os-impl-no-sockets.c: OSAL_CONFIG_INCLUDE_NETWORK FALSE

Expected behavior
Should compile

Code snips
Many of the implementations don't match, sample:

src/os/portable/os-impl-no-sockets.c:52:7: error: conflicting types for ‘OS_SocketOpen_Impl’
 int32 OS_SocketOpen_Impl(uint32 sock_id)
src/os/shared/inc/os-shared-sockets.h:54:7: note: previous declaration of ‘OS_SocketOpen_Impl’ was here
 int32 OS_SocketOpen_Impl(const OS_object_token_t *token);

System observed on:

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions cFS Bundle

Additional context
Seen when adding a coverage test for this code (#795)

Reporter Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the bug label Feb 10, 2021
@skliper skliper added this to the 6.0.0 milestone Feb 10, 2021
@skliper skliper self-assigned this Feb 10, 2021
@skliper skliper mentioned this issue Feb 10, 2021
Closed
skliper added a commit to skliper/osal that referenced this issue Feb 10, 2021
@skliper
Fix nasa#796, Update os-impl-no-sockets.c to match APIs
0e76b63
@skliper skliper mentioned this issue Feb 10, 2021
Merged
astrogeco added a commit that referenced this issue Feb 12, 2021
@astrogeco
Merge pull request #800 from skliper/fix796-no_sockets
2e482ff 
Fix #796, Update os-impl-no-sockets.c to match APIs
astrogeco added a commit that referenced this issue Feb 12, 2021
@astrogeco
Merge pull request #800 from skliper/fix796-no_sockets
920fde8 
Fix #796, Update os-impl-no-sockets.c to match APIs
astrogeco added a commit that referenced this issue Feb 12, 2021
@astrogeco
Merge pull request #800 from skliper/fix796-no_sockets
c24982d 
Fix #796, Update os-impl-no-sockets.c to match APIs
skliper added a commit to skliper/osal that referenced this issue Feb 12, 2021
@skliper
Fix nasa#796, Apply formatting
831100a
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#796, Remove dependency on CCSDS version define
b70a1a3 
- Removes MESSAGE_FORMAT_IS_CCSDS_VER2 and all references
- Now replaced by MISSION_MSGID_V2 and MISSION_INCLUDE_CCSDS_HEADER
  cmake variables
- Base MIDs localized to cpu1_msgids.h and improved documentation
  indicating example nature of implementation, note issue nasa#732
  may make this obsolete
- Updated cfe_sb.dox for message module concept
- MsgId base type now always uint32 (reduces logic differences)
- Removed system log report of version used, in build and obvious
  from packet sizes
- Cleaned extra documentation from cfe_sb_msg_id_util.c
- Removed verification limits on CFE_PLATFORM_SB_MAX_MSG_IDS
- Removed UT_GetActualPktLenField and UT_GetActualCmdCodeField
  that depended on the define, shouldn't directly access message
  in a unit test since it's implementation dependent
- Default CCSDS version default now always 0 (per the standard)
  but mission configurable
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#880 from skliper/fix796-reduce-ver-depend
e01d421 
Fix nasa#796, Remove dependency on CCSDS version define
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
bug public-api
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #796, Update os-impl-no-sockets.c to match APIs skliper/osal
2 participants
@skliper @astrogeco