Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cFS Bundle Integration Candidate: 2020-11-10 #156

Merged
merged 15 commits into from
Nov 16, 2020
Merged

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Nov 10, 2020

Describe the contribution
Includes
nasa/cFE#1008
nasa/osal#652
nasa/to_lab#65
nasa/sample_app#108
nasa/ci_lab#60

Testing performed
Bundle CI on astrogeco's fork: https://travis-ci.com/github/astrogeco/cFS/builds/201769124

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Code contibutions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@zanzaben
@CDKnightNASA
@jphickey

@astrogeco
Copy link
Contributor Author

astrogeco commented Nov 13, 2020

@jphickey and @skliper

Everything builds on Ubuntu Bionic but make install fails on Focal RELEASE builds

https://travis-ci.com/github/astrogeco/cFS/builds/201379042

In file included from /usr/include/string.h:495,

                 from /home/travis/build/astrogeco/cFS/cfe/fsw/cfe-core/src/es/cfe_es_apps.c:49:

In function ‘strncpy’,

    inlined from ‘CFE_ES_StartAppTask’ at /home/travis/build/astrogeco/cFS/cfe/fsw/cfe-core/src/es/cfe_es_apps.c:554:9:

/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output may be truncated copying 19 bytes from a string of length 19 [-Werror=stringop-truncation]

  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));

      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

cc1: all warnings being treated as errors

@astrogeco
Copy link
Contributor Author

astrogeco commented Nov 16, 2020

I'm going to go ahead and merge this and open a new issue to fix the issue in Focal builds

Edit: See nasa/cFE#1016

@astrogeco astrogeco changed the title Integration Candidate: 2020-11-10 cFS Bundle Integration Candidate: 2020-11-10 Nov 16, 2020
@astrogeco astrogeco marked this pull request as ready for review November 16, 2020 14:51
@astrogeco astrogeco merged commit 80c75ce into main Nov 16, 2020
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants