Fix #1012, Include cfe_private.h in stubs #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
I suppose this explains why the build didn't catch this type mismatch. Hopefully this is just a short term fix though -- Ideally I'd like to see the private/ subdir go away completely as part of the refactor proposed in #972.
astrogeco
approved these changes
Nov 13, 2020
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Nov 13, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 16, 2020
* Add nasa/cFE#984 * Add nasa/cFE#980 * Add nasa/cFE#867 * Add nasa/osal#638 and update cfe due to rebase * Add nasa/cFE#987 * Add nasa/to_lab#64 and nasa/sample_app#104 * Add nasa/osal#643 * Add nasa/cFE#1000 * Add nasa/ci_lab#58 * Add doxygen fixes for nasa/osal#643 * Add nasa/cFE#1013 * Add nasa/cFE#1011 * Add nasa/ci_lab#61 * Add nasa/sample_app#109 * Bump versions and point to submodules main Co-authored-by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1012 - added inclusion of cfe_private.h for stubs that implement related elements
Testing performed
Built unit test, confirmed expected failure for CFE_ES_RegisterCDSEx (#1010)
Expected behavior changes
Avoids future divergence.
System(s) tested on
Additional context
Depends on #1011 to pass
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC