Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #59, Remove non-portable OS_PACK #61

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 13, 2020

Describe the contribution
Fix #59 - removes OS_PACK (not portable)

Testing performed
Didn't confirm offsets, but checked size before and after and there was no change (36). cFS-GroundSystem doesn't display the message, but passed unit tests and ran a few commands through the system.

Expected behavior changes
No impact, but removes undesirable pattern

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
Will update other patterns to match #1009 in a separate commit/PR.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 2.5.0 milestone Nov 13, 2020
@astrogeco astrogeco changed the base branch from main to integration-candidate November 13, 2020 20:08
@astrogeco astrogeco merged commit b8f96aa into nasa:integration-candidate Nov 13, 2020
astrogeco added a commit to astrogeco/cFS that referenced this pull request Nov 13, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 16, 2020
* Add nasa/cFE#984

* Add nasa/cFE#980

* Add nasa/cFE#867

* Add nasa/osal#638 and update cfe due to rebase

* Add nasa/cFE#987

* Add nasa/to_lab#64 and nasa/sample_app#104

* Add nasa/osal#643

* Add nasa/cFE#1000

* Add nasa/ci_lab#58

* Add doxygen fixes for nasa/osal#643

* Add nasa/cFE#1013

* Add nasa/cFE#1011

* Add nasa/ci_lab#61

* Add nasa/sample_app#109

* Bump versions and point to submodules main

Co-authored-by: Joseph Hickey <[email protected]>
@skliper skliper deleted the fix59-rm-os_pack branch February 1, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of OS_PACK
2 participants