Integration Candidate: 2020-11-10 #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark static modules with a different type, and check that type at unload. Only call unload low level implementation if type is dynamic.
Add flags to indicate symbol visibility for OS_ModuleLoad(). By default (flags=0) symbols will have global visibility, which should be the same as existing behavior.
This restores the original behavior when using OS_SymbolLookup on POSIX, so it doesn't return OS_ERR_NOT_IMPLEMENTED. This is required for transitional purposes. Will submit a separate bug about use platform-dependent logic here.
Fix #637, fix OS_ModuleUnload for static modules
Fix #641, add OS_ModuleLoad flags
|
@jphickey Got a test failure |
|
@astrogeco make sure the dependency is also pulled into the build: nasa/cFE#1000 |
|
@jphickey doxygen error up next |
jphickey
force-pushed
the
integration-candidate
branch
from
b290347
to
8a9e736
Compare
Add doxygen comment for flags parameter on OS_ModuleLoad Also correct the capitalization of parameters to the OS_ModuleSymbolLookup which caused them to be reported as undocumented.
|
Doxygen issue is fixed on commit 3f5e8f3 (the force earlier was to just to revert an incomplete fix that I pushed too soon - its all good now). |
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Rather than CFE generating an osconfig.h file directly, it just needs to select file(s) from the defs directory and pass them to OSAL for the config.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#652, cmake-based OSAL config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #637, static module unload fix
Fix #641, add flags to OS_ModuleLoad
Testing performed
Bundle CI on astrogeco: https://travis-ci.com/github/astrogeco/cFS/builds/201769124
Expected behavior changes
PR #638 - Ensure that the handle is not NULL before invoking dlclose(). In particular the handle will be NULL for static modules. Shutdown after CTRL+C occurs normally (no segfault).
PR #643 - Add a "flags" parameter to OS_ModuleLoad() to indicate the desired symbol visibility:
CFE should use LOCAL flag for apps, and GLOBAL flags for libraries.
System(s) tested on
Additional context
Part of nasa/cFS#156
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey