Fix #999, Add flags parameter to module load #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @astrogeco -- this is the needed CFE change that correlates with the OSAL PR that we reviewed in the recent CCB. This would need to be merged in the same cycle as the OSAL change. |
skliper
approved these changes
Nov 4, 2020
astrogeco
approved these changes
Nov 12, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 12, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 16, 2020
* Add nasa/cFE#984 * Add nasa/cFE#980 * Add nasa/cFE#867 * Add nasa/osal#638 and update cfe due to rebase * Add nasa/cFE#987 * Add nasa/to_lab#64 and nasa/sample_app#104 * Add nasa/osal#643 * Add nasa/cFE#1000 * Add nasa/ci_lab#58 * Add doxygen fixes for nasa/osal#643 * Add nasa/cFE#1013 * Add nasa/cFE#1011 * Add nasa/ci_lab#61 * Add nasa/sample_app#109 * Bump versions and point to submodules main Co-authored-by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add flags parameter to calls to OS_ModuleLoad().
Initially just pass 0 (GLOBAL) to maintain old behavior.
Fixes #999
Testing performed
Build and sanity test CFE
Run all unit tests.
Expected behavior changes
None - the GLOBAL (0) flag should maintain exact same behavior.
System(s) tested on
Ubuntu 20.04
Additional context
Dependency on nasa/osal#643 - needs to be merged simultaneously
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.