Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #468, Adding coverage for cfe_es_task.c #1653

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

pepepr08
Copy link
Contributor

@pepepr08 pepepr08 commented Jun 29, 2021

Describe the contribution
Fix #468

Test the following cases:

  • CFE_ES_TaskMain() with a CFE_ES_TaskInit() error
  • Query tasks command with valid lib ID
  • Error when sending Build Info event
  • CFE_ES_GenerateVersionEvents() error when sending mission event

Testing performed
Manually ran unit tests for ES: $ make -C build/native/default_cpu1/es test
Verified coverage on files with gcov cfe_es_task.c.gcno and gcov cfe_es_task.c.gcno

Expected behavior changes
Increased coverage percentage.

System(s) tested on

  • Ubuntu 18.04 VM

Contributor Info - All information REQUIRED for consideration of pull request
Jose F. Martinez Pedraza/NASA GSFC

@pepepr08 pepepr08 changed the title Fix #468, Adding coverage for cfe_es_task.c DRAFT: Fix #468, Adding coverage for cfe_es_task.c Jun 29, 2021
@pepepr08 pepepr08 changed the title DRAFT: Fix #468, Adding coverage for cfe_es_task.c (WIP) Fix #468, Adding coverage for cfe_es_task.c Jun 29, 2021
@pepepr08 pepepr08 added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 30, 2021
@pepepr08 pepepr08 requested a review from skliper June 30, 2021 12:53
@pepepr08 pepepr08 marked this pull request as ready for review June 30, 2021 13:02
@pepepr08 pepepr08 changed the title (WIP) Fix #468, Adding coverage for cfe_es_task.c Fix #468, Adding coverage for cfe_es_task.c Jun 30, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jun 30, 2021
@astrogeco
Copy link
Contributor

CCB:2021-06-30 APPROVED

Test the following cases:
- CFE_ES_TaskMain() with a CFE_ES_TaskInit() error
- Query tasks command with valid lib ID
- Error when sending Build Info event
- CFE_ES_GenerateVersionEvents() error when sending mission event
- Loop coverage for CFE_ES_FindConfigKeyValue()
@astrogeco astrogeco changed the base branch from main to integration-candidate June 30, 2021 19:47
@astrogeco astrogeco merged commit be48cda into nasa:integration-candidate Jun 30, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 30, 2021
**Combines**
nasa/cFE#1654

**Includes**

nasa/cFE#1444, Change index type to resolve infinite loop warning
nasa/cFE#1653, Adding coverage for cfe_es_task.c
nasa/cFE#1638, Expand FS Header Functional tests.
astrogeco added a commit to nasa/cFS that referenced this pull request Jul 7, 2021
**Combines**

nasa/cFE#1654, cfe v6.8.0-rc1+dev739
nasa/osal#1098, osal v5.1.0-rc1+dev564

**Includes**

nasa/cFE#1444, Change index type to resolve infinite loop warning
nasa/cFE#1653, Adding coverage for cfe_es_task.c
nasa/cFE#1638, Expand FS Header Functional tests.
nasa/cFE#1637, Complete coverage for cfe_es_start.c and cfe_es_syslog.c

nasa/osal#1081, add range to OS_TaskDelay checks
nasa/osal#1085, return OS_OBJECT_ID_UNDEFINED for root task ID on RTEMS
nasa/osal#1090, increase UT symbol dump size limit
nasa/osal#1091, do not register RTOS timer for external sync
nasa/osal#1093, avoid task delete during UtPrintf
nasa/osal#1097, Add osal prefix to Network API group
nasa/osal#1092, increase timeout in network-api-test

Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Joseph Hickey <[email protected]>
Co-authored-by: Alex Campbell <[email protected]>
Co-authored-by: Jose F Martinez Pedraza <[email protected]>
Co-authored-by: Himanshu <[email protected]>
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete coverage test for cfe_es_task.c
3 participants