Fix #467, #1636 Complete coverage for cfe_es_start.c and cfe_es_syslog.c #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepepr08
force-pushed
the
fix467-es-start-syslog
branch
from
2d73c9b
to
f96f9db
Compare
Completed 100% coverage on cfe_es_start.c
pepepr08
force-pushed
the
fix467-es-start-syslog
branch
from
f96f9db
to
46fedff
Compare
pepepr08
added
the
CCB:Ready
|
DEV:2021-06-22, @skliper do we want to merge this even though it modifies fsw? |
skliper
approved these changes
Jun 25, 2021
|
@astrogeco - Yes, it was dead code so removal is appropriate in prep for release. |
zanzaben
approved these changes
Jun 25, 2021
astrogeco
changed the title
astrogeco
added
CCB:Approved
|
CCB:2021-06-30 APPROVED with CHANGES
|
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 2, 2021
nasa/cFE#1637, Complete coverage for cfe_es_start.c and cfe_es_syslog.c
This was referenced Jul 7, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 7, 2021
**Combines** nasa/cFE#1654, cfe v6.8.0-rc1+dev739 nasa/osal#1098, osal v5.1.0-rc1+dev564 **Includes** nasa/cFE#1444, Change index type to resolve infinite loop warning nasa/cFE#1653, Adding coverage for cfe_es_task.c nasa/cFE#1638, Expand FS Header Functional tests. nasa/cFE#1637, Complete coverage for cfe_es_start.c and cfe_es_syslog.c nasa/osal#1081, add range to OS_TaskDelay checks nasa/osal#1085, return OS_OBJECT_ID_UNDEFINED for root task ID on RTEMS nasa/osal#1090, increase UT symbol dump size limit nasa/osal#1091, do not register RTOS timer for external sync nasa/osal#1093, avoid task delete during UtPrintf nasa/osal#1097, Add osal prefix to Network API group nasa/osal#1092, increase timeout in network-api-test Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]> Co-authored-by: Himanshu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Completed code coverage for
cfe_es_start.candcfe_es_syslog.cwith the following changes:Fixes #467 The following tests were added:
CFE_ES_Mainwith a ES Perf Data mutex creation failureCFE_ES_CreateObjectswith unknown object typeCFE_ES_SysLogReadDatawhen calculated blocksize is 0Fixes #1636 removed function
CFE_ES_SysLog_snprintfTesting performed
Manually ran unit tests for ES:
$ make -C build/native/default_cpu1/es testVerified 100% coverage on files with
gcov cfe_es_syslog.c.gcnoandgcov cfe_es_start.c.gcnoExpected behavior changes
Increased overall code coverage
System(s) tested on
Additional context
Contributor Info - All information REQUIRED for consideration of pull request
Jose F. Martinez Pedraza/NASA GSFC