Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1480, Expand FS Header Functional tests. #1638

Conversation

zanzaben
Copy link
Contributor

Describe the contribution
Fixes #1480
Expands FS Header functional tests to include error checking.

Testing performed
Build and run unit test

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@astrogeco astrogeco changed the base branch from main to integration-candidate June 24, 2021 19:30
@astrogeco astrogeco added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 24, 2021
@astrogeco astrogeco changed the base branch from integration-candidate to main June 24, 2021 19:37
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming internal macros to make it clear these are not supplied by utassert. Local naming would also avoid potential future conflicts...

@zanzaben zanzaben force-pushed the fix1489_expend_FS_Header_functional_tests branch from 1146ccb to 1c0fa95 Compare June 28, 2021 17:27
@zanzaben zanzaben force-pushed the fix1489_expend_FS_Header_functional_tests branch from 1c0fa95 to 30d1b54 Compare June 28, 2021 18:58
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jun 30, 2021
@astrogeco
Copy link
Contributor

CCB:2021-06-30 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate June 30, 2021 19:48
@astrogeco astrogeco merged commit 85e0e78 into nasa:integration-candidate Jun 30, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 30, 2021
**Combines**
nasa/cFE#1654

**Includes**

nasa/cFE#1444, Change index type to resolve infinite loop warning
nasa/cFE#1653, Adding coverage for cfe_es_task.c
nasa/cFE#1638, Expand FS Header Functional tests.
astrogeco added a commit to nasa/cFS that referenced this pull request Jul 7, 2021
**Combines**

nasa/cFE#1654, cfe v6.8.0-rc1+dev739
nasa/osal#1098, osal v5.1.0-rc1+dev564

**Includes**

nasa/cFE#1444, Change index type to resolve infinite loop warning
nasa/cFE#1653, Adding coverage for cfe_es_task.c
nasa/cFE#1638, Expand FS Header Functional tests.
nasa/cFE#1637, Complete coverage for cfe_es_start.c and cfe_es_syslog.c

nasa/osal#1081, add range to OS_TaskDelay checks
nasa/osal#1085, return OS_OBJECT_ID_UNDEFINED for root task ID on RTEMS
nasa/osal#1090, increase UT symbol dump size limit
nasa/osal#1091, do not register RTOS timer for external sync
nasa/osal#1093, avoid task delete during UtPrintf
nasa/osal#1097, Add osal prefix to Network API group
nasa/osal#1092, increase timeout in network-api-test

Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Joseph Hickey <[email protected]>
Co-authored-by: Alex Campbell <[email protected]>
Co-authored-by: Jose F Martinez Pedraza <[email protected]>
Co-authored-by: Himanshu <[email protected]>
@zanzaben zanzaben deleted the fix1489_expend_FS_Header_functional_tests branch July 12, 2021 14:08
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FS Header Functional Tests
4 participants