Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1184, Change index type to resolve infinite loop warning #1444

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Fix #1184, Change index type to resolve infinite loop warning #1444

merged 1 commit into from
Jun 30, 2021

Conversation

himanshu007-creator
Copy link
Contributor

@himanshu007-creator himanshu007-creator commented Apr 29, 2021

Describe the contribution
A clear and concise description of what the contribution is.

Testing performed
Steps taken to test the contribution:

  1. Build steps '...'
  2. Execution steps '...'

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • If NASA Civil Servant Employee or GSFC Contractor on SES II

    • Address/email/phone and contract/task information (if applicable) must be on file
  • Else if Company

    • HAND SIGNED Company CLA must be on file (once per release): Company CLA
  • Else if Individual

    • HAND SIGNED Individual CLA must be on file (once per release): Individual CLA
  • Individual CLA
    Himanshu CLA.pdf

@skliper skliper added this to the 7.0.0 milestone May 28, 2021
@skliper skliper closed this Jun 3, 2021
@skliper skliper deleted the branch nasa:integration-candidate June 3, 2021 15:06
@skliper
Copy link
Contributor

skliper commented Jun 23, 2021

This one got auto-closed since the base branch wasn't set correctly and got removed. Need to resurrect or resubmit.

@himanshu007-creator
Copy link
Contributor Author

hi @skliper , should i send another PR with changing branch to master?

@skliper skliper reopened this Jun 23, 2021
@skliper skliper changed the base branch from eval-msg-module to main June 23, 2021 17:04
@jphickey
Copy link
Contributor

Appears to still be a major baseline mismatch here. Can we just cherry-pick the commit onto the current main. Looks like we just need commit bcd12d2

@skliper
Copy link
Contributor

skliper commented Jun 23, 2021

Hi @himanshu007-creator - I did just reopen it so you could fix by just rebasing this branch on main and force pushing.

@himanshu007-creator
Copy link
Contributor Author

rebasing this branch on main

hi @skliper , i am unable to do the rebasung, can you take it from here?
Thanks

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 28, 2021
@astrogeco astrogeco changed the title Update ut_support.c Fix #1184, Update ut_support.c Jun 28, 2021
@astrogeco astrogeco changed the title Fix #1184, Update ut_support.c Fix #1184, Change index type to resolve infinite loop warning Jun 28, 2021
Static Analysis Warning - Infinite loop false alarm in unit test
@astrogeco
Copy link
Contributor

Force pushed an amendment to the commit message to align with contribution standard

@astrogeco astrogeco added community Community contribution, YAY! CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jun 28, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate June 30, 2021 19:44
@astrogeco astrogeco merged commit e74b4fe into nasa:integration-candidate Jun 30, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 30, 2021
**Combines**
nasa/cFE#1654

**Includes**

nasa/cFE#1444, Change index type to resolve infinite loop warning
nasa/cFE#1653, Adding coverage for cfe_es_task.c
nasa/cFE#1638, Expand FS Header Functional tests.
astrogeco added a commit to nasa/cFS that referenced this pull request Jul 7, 2021
**Combines**

nasa/cFE#1654, cfe v6.8.0-rc1+dev739
nasa/osal#1098, osal v5.1.0-rc1+dev564

**Includes**

nasa/cFE#1444, Change index type to resolve infinite loop warning
nasa/cFE#1653, Adding coverage for cfe_es_task.c
nasa/cFE#1638, Expand FS Header Functional tests.
nasa/cFE#1637, Complete coverage for cfe_es_start.c and cfe_es_syslog.c

nasa/osal#1081, add range to OS_TaskDelay checks
nasa/osal#1085, return OS_OBJECT_ID_UNDEFINED for root task ID on RTEMS
nasa/osal#1090, increase UT symbol dump size limit
nasa/osal#1091, do not register RTOS timer for external sync
nasa/osal#1093, avoid task delete during UtPrintf
nasa/osal#1097, Add osal prefix to Network API group
nasa/osal#1092, increase timeout in network-api-test

Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Joseph Hickey <[email protected]>
Co-authored-by: Alex Campbell <[email protected]>
Co-authored-by: Jose F Martinez Pedraza <[email protected]>
Co-authored-by: Himanshu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB community Community contribution, YAY!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop false alarm in unit test (easy fix) - static analysis warning
4 participants