-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add canvas mode that doesn't rely on vite #3171
Conversation
I'm trying this now and it seems like when running |
When I do
and then
it opens http://localhost:3000/prod/editor/ for me I have # .env
EXPERIMENTAL_INLINE_CANVAS=1 |
One problem I'm experiencing in this mode is with
and then opening http://localhost:3000/prod/editor/app/pages/components |
Weird, it's working fine for me when I tried now. Maybe something was wrong on my local environment yesterday...
Just tried it and it seems to work fine for me? |
Make sure to have |
Ah I had forgotten to set the environment variable in the test fixture. Can confirm the issue! |
First batch of changes that renders the canvas in the same react tree as the editor instead of loading a page in an iframe. Currently behind a flag
EXPERIMENTAL_INLINE_CANVAS
because more work is required to make it the main rendering mode. But aiming to already merge this as to avoid accumulating many big architectural changes in one PR.Now the editor is hosted under the same path as the app:
things that are now fixed
add to the .env file to play with this:
# .env EXPERIMENTAL_INLINE_CANVAS=1
To do (in follow up):