Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project loading several times #3188

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Fix project loading several times #3188

merged 3 commits into from
Feb 9, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 9, 2024

The editor project is loading several times due to suspense. This leads to event handlers created multiple times. This change creates the project in an effect instead.

Fix needed for EXPERIMENTAL_INLINE_CANVAS

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Feb 9, 2024
@Janpot Janpot marked this pull request as ready for review February 9, 2024 16:46
@Janpot Janpot requested a review from a team February 9, 2024 16:47
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I had noticed this.

@Janpot Janpot merged commit 7acbb93 into mui:master Feb 9, 2024
10 of 11 checks passed
@Janpot Janpot deleted the fix-reload branch February 9, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants