Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroute "open in editor" link in app preview #3207

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 13, 2024

Make sure the new editor opens when clicking "open in editor" in the app preview.

Also deprecate the editor command for custom servers.

Also in this PR:

  • add some margin to the togglebutton prop control
  • fix HMR and react refresh when running with the --dev command
    • point to typescript sources instead of build output
    • remove non-component exports from Toolpad.tsx

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Feb 13, 2024
@Janpot Janpot marked this pull request as ready for review February 13, 2024 13:50
@Janpot Janpot requested a review from a team February 13, 2024 13:50
@bharatkashyap
Copy link
Member

Does it make sense here to add a screenshot/videos of the changed behaviour to the PR description?

@Janpot
Copy link
Member Author

Janpot commented Feb 14, 2024

Does it make sense here to add a screenshot/videos of the changed behaviour to the PR description?

The only thing that changes is the url of the editor. And the speed at which it opens

@Janpot Janpot merged commit ff072e2 into mui:master Feb 15, 2024
11 checks passed
@Janpot Janpot deleted the reroute-preview-link branch February 15, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants