Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for code components under new editor runtime #3193

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 10, 2024

The new editor that runs side by side with the app runtime now reloads when a component is added. This is caused by vitejs/vite#12912. Before only the app runtime reloaded, but now the editor and app are one single react tree. This PR teaches the tests to anticipate this reload.

I suppose we can live with this for now, the whole editor became more responsive at the cost of a single reload whenc reating a new component. The ways to fix it are either

@Janpot Janpot added the test label Feb 10, 2024
@Janpot Janpot marked this pull request as ready for review February 10, 2024 11:10
@Janpot Janpot requested a review from a team February 10, 2024 11:10
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole editor became more responsive at the cost of a single reload when creating a new component

Yeah seems like a good trade-off.

@Janpot Janpot merged commit f94e1b6 into mui:master Feb 13, 2024
11 checks passed
@Janpot Janpot deleted the code-component-test branch February 13, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to hmr accept virtual modules
2 participants