Create predictably named test directories #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
| @@ -58,9 +58,23 @@ interface LocalServerConfig { | |||
| env?: Record<string, string>; | |||
| base?: string; | |||
| } | |||
| export async function getTemporaryDir() { | |||
There was a problem hiding this comment.
Do we still need this function? I see it's only being used in a custom server test now, not sure if it could be replaced there too?
There was a problem hiding this comment.
yes, it's using a random directory that's different from the test directory
apedroferreira
approved these changes
Feb 12, 2024
|
Oh, unrelated but could we gitignore these temporary test folders? |
I've thought about it as well, but ideally you remove them instead of ignoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid vite configs changing and triggering dependency optimization.
This replaces the random test directory name with one that's based on the parallel index of the current worker. If amount of workers is set at 1 (which we already do), the tests will always operate on the same folder and the dependency optimization won't invalidate.