Update vcpkg-tool to 2023-06-07 + xbox triplets cleanup#31723
Update vcpkg-tool to 2023-06-07 + xbox triplets cleanup#31723BillyONeal merged 6 commits intomicrosoft:masterfrom
Conversation
BillyONeal
added
info:internal
category:infrastructure
https://github.com/microsoft/vcpkg-tool/releases/tag/2023-05-30 + https://github.com/microsoft/vcpkg-tool/releases/tag/2023-05-31 Clean up xbox triplets following teaching vcpkg.exe about xbox more directly. Also deletes the seemingly-no-longer-used vcpkg_get_dep_info.cmake and vcpkg_get_tags.cmake.
BillyONeal
force-pushed
the
tool-update-2023-05-30
branch
from
34afbce to
f4b7248
Compare
| if(DEFINED VCPKG_XBOX_CONSOLE_TARGET) | ||
| vcpkg_list(APPEND arg_OPTIONS "-DXBOX_CONSOLE_TARGET=${VCPKG_XBOX_CONSOLE_TARGET}") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Yeah world rebuilds for everyone..... just for a "clean" triplet (whatever that means.)
There was a problem hiding this comment.
just for a "clean" triplet (whatever that means.)
For example, when compiling for xbox this makes the binary cache depend on the version of the GXDK used rather than the file path.
There was a problem hiding this comment.
For example, when compiling for xbox this makes the binary cache depend on the version of the GXDK used rather than the file path.
There was a problem hiding this comment.
That would mean the GXDK was not included at all.
There was a problem hiding this comment.
I mean MS can have magic in the tool for special cases as much as it wants but that sounds like a use case for microsoft/vcpkg-tool#816
There was a problem hiding this comment.
There are ways to pass platform-specific options from the triplet to the maintainer functions. I would prefer to not add more platform-specific code into scripts which are ABI-tracked for all platforms when the use case can be handled in specific triplet files.
There was a problem hiding this comment.
The vcpkg team spoke very briefly about this at a team meeting this morning. We agree that we will reconsider this design approach for future settings, and investigate if alternatives to our existing "VCPKG_<foo> becomes <foo>" for every setting we wish to create would provide a better caching experience. However, we already have enough agreements in place for this particular change that we wish to move forward with this design as is. Note that this design is consistent with all other VCPKG_<foo> triplet variables such as VCPKG_CXX_FLAGS.
=======================================
Speaking personally, a couple notes:
- I agree that avoiding needlessly invalidating binary caches is a good thing.
- I agree that, wherever possible, we should have a design that doesn't need to invalidate binary caches whenever we add a new knob.
- I do not believe we currently have a design capable of achieving that, but we will look at trying to do that next time, including by, for example, implementing the option entirely in-tool.
- I do not agree that anything that could be done with custom triplets requiring 6+ settings to be expertly set perfectly is an acceptable outcome for experiences we want to be first class. (And we do want xbox to be first class)
- I think this calls into question all VCPKG_TARGET_IS settings and think we should strongly consider not adding any more.
BillyONeal
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Something is making that one particular machine very angry:
I'm not sure if this is a tool change issue or a machine issue; all the bad_alloc and stack buffer overrun failures seem to be coming from the same one... |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This also reverts all starlink-ast changes in favor of microsoft#31663
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
changed the title
) * Update vcpkg-tool to 2023-05-31 + xbox triplets cleanup https://github.com/microsoft/vcpkg-tool/releases/tag/2023-05-30 + https://github.com/microsoft/vcpkg-tool/releases/tag/2023-05-31 + https://github.com/microsoft/vcpkg-tool/releases/tag/2023-06-07 Clean up xbox triplets following teaching vcpkg.exe about xbox more directly. Also deletes the seemingly-no-longer-used vcpkg_get_dep_info.cmake and vcpkg_get_tags.cmake. Also: [redis-plus-plus] Add DISABLE_PARALLEL_CONFIGURE due to source tree write.
5 participants
https://github.com/microsoft/vcpkg-tool/releases/tag/2023-05-30
Clean up xbox triplets following teaching vcpkg.exe about xbox more directly.
Also deletes the seemingly-no-longer-used vcpkg_get_dep_info.cmake and vcpkg_get_tags.cmake.