Skip to content

[starlink-ast] Switch tarball, misc fixes#31663

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
dg0yt:starlink-ast
Jun 5, 2023
Merged

[starlink-ast] Switch tarball, misc fixes#31663
dan-shaw merged 2 commits intomicrosoft:masterfrom
dg0yt:starlink-ast

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented May 27, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt dg0yt force-pushed the starlink-ast branch 3 times, most recently from e0eee87 to 85d7aaf Compare May 28, 2023 06:04
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 29, 2023
@dg0yt dg0yt force-pushed the starlink-ast branch 2 times, most recently from 1cfee02 to bd36437 Compare June 3, 2023 12:00
@dg0yt dg0yt mentioned this pull request Jun 3, 2023
Closed
@dg0yt dg0yt changed the title [starlink-ast] WIP [starlink-ast] Switch tarball, misc fixes Jun 3, 2023
@dg0yt dg0yt marked this pull request as ready for review June 3, 2023 12:09
@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented Jun 5, 2023

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

@MonicaLiu0311 MonicaLiu0311 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 5, 2023
@dan-shaw dan-shaw merged commit c48c767 into microsoft:master Jun 5, 2023
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Jun 5, 2023
@BillyONeal
Merge remote-tracking branch 'origin/master' into tool-update-2023-05-30
53df498 
This also reverts all starlink-ast changes in favor of microsoft#31663
@dg0yt dg0yt deleted the starlink-ast branch June 6, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dg0yt @MonicaLiu0311 @dan-shaw @FrankXie05