[triplet] xbox triplet fixes for handling Build Without Install#44122
Merged
JavierMatosD merged 1 commit intomicrosoft:masterfrom Mar 3, 2025
Merged
[triplet] xbox triplet fixes for handling Build Without Install#44122JavierMatosD merged 1 commit intomicrosoft:masterfrom
JavierMatosD merged 1 commit intomicrosoft:masterfrom
Conversation
LilyWangLL
added
the
category:tool-update
LilyWangLL
approved these changes
Mar 3, 2025
LilyWangLL
added
the
info:needs-maintainer-attention
BillyONeal
reviewed
Mar 4, 2025
walbourn
added a commit
to walbourn/vcpkg
that referenced
this pull request
Mar 4, 2025
…em.process.cpp
walbourn
added a commit
to walbourn/vcpkg
that referenced
this pull request
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the initial implementation of the xbox triplets, I had them pass through some key environment variables. These were removed in #31723.
For cases where the Microsoft GDK is actually installed on the machine, these variables were globally defined in the system environment so still worked. Now that I'm trying to use those variables in a "Build Without Install" scenario for cloud-builds, the regression has now become apparent.