Skip to content

[redis-plus-plus]Update version to 1.3.8#31851

Merged
dan-shaw merged 4 commits intomicrosoft:masterfrom
FrankXie05:dev/Frank/31845
Jun 7, 2023
Merged

[redis-plus-plus]Update version to 1.3.8#31851
dan-shaw merged 4 commits intomicrosoft:masterfrom
FrankXie05:dev/Frank/31845

Conversation

@FrankXie05
Copy link
Contributor

Fix #31845

Note: Update redis-plus-plus version 1.3.8.

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-stataic
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Jun 6, 2023
@FrankXie05
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05 FrankXie05 marked this pull request as ready for review June 7, 2023 05:55
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 7, 2023
@dan-shaw dan-shaw merged commit 8f721da into microsoft:master Jun 7, 2023
CHECK_SYMBOL_EXISTS(redisEnableKeepAliveWithInterval ${HIREDIS_FEATURE_TEST_HEADER} REDIS_PLUS_PLUS_HAS_redisEnableKeepAliveWithInterval)

-configure_file(${CMAKE_CURRENT_SOURCE_DIR}/hiredis_features.h.in ${CMAKE_CURRENT_SOURCE_DIR}/${REDIS_PLUS_PLUS_SOURCE_DIR}/hiredis_features.h)
+configure_file("${CMAKE_CURRENT_SOURCE_DIR}/hiredis_features.h.in" "${CMAKE_CURRENT_SOURCE_DIR}/${REDIS_PLUS_PLUS_SOURCE_DIR}/hiredis_features.h")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This writes to the source directory so it needs DISABLE_PARALLEL_CONFIGURE. Will fix in #31723

@FrankXie05 FrankXie05 deleted the dev/Frank/31845 branch June 8, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[redis-plus-plus] build failure

4 participants