[lionkor-commandline] Add new port by Pospelove · Pull Request #23471 · microsoft/vcpkg

Pospelove · 2022-03-10T01:13:25Z

Describe the pull request

What does your PR fix?

Fixes [New Port Request] commandline #23459
Which triplets are supported/not supported? Have you updated the CI baseline?

<all / linux, windows, ...>, <Yes/No>
Does your PR follow the maintainer guide?

Your answer
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

<Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/commandline/vcpkg.json b/ports/commandline/vcpkg.json
index 93c3393..52b5dd8 100644
--- a/ports/commandline/vcpkg.json
+++ b/ports/commandline/vcpkg.json
@@ -1,8 +1,8 @@
-{
-  "name": "commandline",
-  "version-semver": "1.0.0",
-  "description": "A C++ commandline for use in servers and chat software. Provides very simple asynchronous input/output.",
-  "homepage": "https://github.com/lionkor/commandline/",
-  "license": "MIT",
-  "supports": "static"
-}
+{
+  "name": "commandline",
+  "version-semver": "1.0.0",
+  "description": "A C++ commandline for use in servers and chat software. Provides very simple asynchronous input/output.",
+  "homepage": "https://github.com/lionkor/commandline/",
+  "license": "MIT",
+  "supports": "static"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index d87a108..c82f668 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,6 +1472,10 @@
       "baseline": "3.7",
       "port-version": 0
     },
+    "commandline": {
+      "baseline": "1.0.0",
+      "port-version": 0
+    },
     "comms": {
       "baseline": "3.4.0",
       "port-version": 1

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/commandline/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index d87a108..c82f668 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,6 +1472,10 @@
       "baseline": "3.7",
       "port-version": 0
     },
+    "commandline": {
+      "baseline": "1.0.0",
+      "port-version": 0
+    },
     "comms": {
       "baseline": "3.4.0",
       "port-version": 1

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for commandline but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: 58aa6f7b74d8b1a876f3a906b65a7f0b2421022c
-- New SHA: 0a624b93bb7e086e520b067dfa82a6c50916c2b4
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for commandline but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: 0a624b93bb7e086e520b067dfa82a6c50916c2b4
-- New SHA: d768b284ac7cdf5d13b7f32a24217bfff2632332
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

JackBoosY · 2022-03-10T02:31:48Z

When building x64-osx:

/Users/vagrant/Data/buildtrees/commandline/src/a4454e07a9-613e01ad85.clean/commandline.cpp:11:10: fatal error: 'conio.h' file not found
#include <conio.h>
         ^~~~~~~~~
1 error generated.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for commandline but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: d768b284ac7cdf5d13b7f32a24217bfff2632332
-- New SHA: 18e1e8483a0a5b81a25fd0efcc87403dcbf64432
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Pospelove · 2022-03-10T02:51:29Z

@JackBoosY marked osx as unsupported

JackBoosY · 2022-03-10T02:54:18Z

Waiting for test results.

ports/commandline/vcpkg.json

ports/commandline/add-install.patch

ports/commandline/portfile.cmake

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for commandline but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: 18e1e8483a0a5b81a25fd0efcc87403dcbf64432
-- New SHA: 518c484843653c6e10980b19997d698fcc046c97
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Pospelove · 2022-03-10T06:41:36Z

@JackBoosY Plz tell me if there is a way to disable debug/include via patch too

ras0219-msft · 2022-03-11T00:35:36Z

Thanks for the PR!

It's fine to just delete debug/include afterwards.

Additionally, the name of this library is extremely generic and there isn't a long history of associating that name with this library. Could you please rename the port to something more unique like lionkor-commandline?

ras0219-msft

See above comment.

…g.json

…portfile.cmake

…ne/add-install.patch

Pospelove · 2022-03-11T01:44:07Z

@ras0219-msft No problem, I've just renamed everything via gh interface. hope it works :)

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..126d188 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,7 +1472,7 @@
       "baseline": "3.7",
       "port-version": 0
     },
-    "lionkor-commandline": {
+    "commandline": {
       "baseline": "1.0.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..126d188 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,7 +1472,7 @@
       "baseline": "3.7",
       "port-version": 0
     },
-    "lionkor-commandline": {
+    "commandline": {
       "baseline": "1.0.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..732196e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,10 +1472,6 @@
       "baseline": "3.7",
       "port-version": 0
     },
-    "lionkor-commandline": {
-      "baseline": "1.0.0",
-      "port-version": 0
-    },
     "comms": {
       "baseline": "3.4.0",
       "port-version": 1
@@ -4192,6 +4188,10 @@
       "baseline": "4754bee2d8eb3",
       "port-version": 2
     },
+    "lionkor-commandline": {
+      "baseline": "1.0.0",
+      "port-version": 0
+    },
     "live555": {
       "baseline": "2021-12-18",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..732196e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,10 +1472,6 @@
       "baseline": "3.7",
       "port-version": 0
     },
-    "lionkor-commandline": {
-      "baseline": "1.0.0",
-      "port-version": 0
-    },
     "comms": {
       "baseline": "3.4.0",
       "port-version": 1
@@ -4192,6 +4188,10 @@
       "baseline": "4754bee2d8eb3",
       "port-version": 2
     },
+    "lionkor-commandline": {
+      "baseline": "1.0.0",
+      "port-version": 0
+    },
     "live555": {
       "baseline": "2021-12-18",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..732196e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,10 +1472,6 @@
       "baseline": "3.7",
       "port-version": 0
     },
-    "lionkor-commandline": {
-      "baseline": "1.0.0",
-      "port-version": 0
-    },
     "comms": {
       "baseline": "3.4.0",
       "port-version": 1
@@ -4192,6 +4188,10 @@
       "baseline": "4754bee2d8eb3",
       "port-version": 2
     },
+    "lionkor-commandline": {
+      "baseline": "1.0.0",
+      "port-version": 0
+    },
     "live555": {
       "baseline": "2021-12-18",
       "port-version": 0

…commandline

* master: (64 commits) [baseline] [python3] fix bz2(d) search on linux (microsoft#23525) [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042) [earcut.hpp] New port (microsoft#23507) [libssh2] Fix deleted configfiles (microsoft#23509) [python3] Update to Python 3.10.2. (microsoft#23156) [qt5-webengine] Fix apply patch failed (microsoft#23484) [llvm] Fix LLVM install for 'utils' feature (microsoft#23399) [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357) [GTL] Add new port (microsoft#23400) [raylib] Fix cannot find -lglfw on Linux (microsoft#23348) [yato] fix arm build by updating (microsoft#23406) [ois] fix pkgconfig file not installed on windows (microsoft#23426) Fix the dependency of installing arrow with the parquet feature (microsoft#23423) [libjpeg-turbo] Fix usage when building static (microsoft#23427) [sentencepiece] Clarify supported triplets (microsoft#23438) [zpp-bits] Add new port (microsoft#23458) [lionkor-commandline] Add new port (microsoft#23471) [libde265] fix static linkage (microsoft#23479) [libheif] fix license (microsoft#23480) [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487) ...

[commandline] Add new port

139700b

github-actions bot requested changes Mar 10, 2022

View reviewed changes

Pospelove marked this pull request as ready for review March 10, 2022 01:14

Pospelove added 2 commits March 10, 2022 04:16

Fix formating

5402959

Fix deps

cb5e0f7

Adela0814 assigned JackBoosY Mar 10, 2022

github-actions bot requested changes Mar 10, 2022

View reviewed changes

Update versions

d394004

github-actions bot approved these changes Mar 10, 2022

View reviewed changes

Remove redudant build

9010535

github-actions bot requested changes Mar 10, 2022

View reviewed changes

Update commandline.json

417b76b

github-actions bot approved these changes Mar 10, 2022

View reviewed changes

Update portfile.cmake

26529e3

github-actions bot requested changes Mar 10, 2022

View reviewed changes

Update commandline.json

f089792

github-actions bot approved these changes Mar 10, 2022

View reviewed changes

JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 10, 2022

JackBoosY added the requires:author-response label Mar 10, 2022

Ban osx

5b0947b

github-actions bot requested changes Mar 10, 2022

View reviewed changes

Update commandline.json

4dcdd3a

github-actions bot approved these changes Mar 10, 2022

View reviewed changes

JackBoosY suggested changes Mar 10, 2022

View reviewed changes

ports/commandline/vcpkg.json Outdated Show resolved Hide resolved

ports/commandline/add-install.patch Outdated Show resolved Hide resolved

ports/commandline/portfile.cmake Outdated Show resolved Hide resolved

ports/commandline/portfile.cmake Outdated Show resolved Hide resolved

Pospelove and others added 2 commits March 10, 2022 09:18

Update ports/commandline/add-install.patch

67d921e

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

Update ports/commandline/portfile.cmake

966f273

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

github-actions bot requested changes Mar 10, 2022

View reviewed changes

lionkor mentioned this pull request Mar 10, 2022

Fatal error when building for x64-osx lionkor/commandline#9

Open

ras0219-msft requested changes Mar 11, 2022

View reviewed changes

Pospelove changed the title ~~[commandline] Add new port~~ [lionkor-commandline] Add new port Mar 11, 2022

Pospelove added 6 commits March 11, 2022 04:36

Rename commandline.json to lionkor-commandline.json

d2afeab

Update baseline.json

3b79661

Update vcpkg.json

07bacc8

Rename ports/commandline/vcpkg.json to ports/lionkor-commandline/vcpk…

77dc1df

…g.json

Rename ports/commandline/portfile.cmake to ports/lionkor-commandline/…

9a1d12e

…portfile.cmake

Rename ports/commandline/add-install.patch to ports/lionkor-commandli…

81a29a5

…ne/add-install.patch

github-actions bot approved these changes Mar 11, 2022

View reviewed changes

Pospelove requested a review from ras0219-msft March 11, 2022 01:43

github-actions bot requested changes Mar 11, 2022

View reviewed changes

Update baseline.json

7e73ee9

github-actions bot approved these changes Mar 11, 2022

View reviewed changes

JackBoosY added 2 commits March 11, 2022 00:55

Merge branch 'master' of https://github.com/microsoft/vcpkg into add-…

9c563ac

…commandline

version

39b9834

JackBoosY approved these changes Mar 11, 2022

View reviewed changes

JackBoosY removed the requires:author-response label Mar 11, 2022

github-actions bot approved these changes Mar 11, 2022

View reviewed changes

JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 11, 2022

vicroms merged commit 95641c8 into microsoft:master Mar 11, 2022

Pospelove deleted the add-commandline branch March 11, 2022 21:24

Conversation

Pospelove commented Mar 10, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented Mar 10, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Pospelove commented Mar 10, 2022

Uh oh!

JackBoosY commented Mar 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Pospelove commented Mar 10, 2022

Uh oh!

ras0219-msft commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ras0219-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Pospelove commented Mar 11, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

ras0219-msft commented Mar 11, 2022 •

edited

Loading