[GTL] Add new port by greg7mdp · Pull Request #23400 · microsoft/vcpkg

greg7mdp · 2022-03-06T17:41:28Z

Adding new GTL port.
This is a new C++20 template library including updated versions of greg7mdp/parallel-hashmap and more.

supports windows (vs2019+), linux and macos (gcc 11.1+ or clang 13+)

Does your PR follow the maintainer guide?

I think so

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtl but no changes to version or port version.
-- Version: 1.00
-- Old SHA: a2988669892dee6569f90d5d0e5dd3296919d3c8
-- New SHA: 7716fa476f8f6bd1d7967e949bc45644e73bc40a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

ports/gtl/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtl but no changes to version or port version.
-- Version: 1.00
-- Old SHA: a2988669892dee6569f90d5d0e5dd3296919d3c8
-- New SHA: 83f0405113b1ff6cddda719ffcf9915df02cc3ea
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Thomas1664 · 2022-03-06T22:06:23Z

When you're done, please run vcpkg x-add-version gtl --overwrite-version and commit the result.

greg7mdp · 2022-03-06T22:21:17Z

When you're done, please run vcpkg x-add-version gtl --overwrite-version and commit the result.

just did, thanks!

ports/gtl/portfile.cmake

greg7mdp · 2022-03-08T12:52:07Z

@JonLiu1993 just changed "version-string" tp "version"

… (semver with arbitrary numeric identifiers)

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtl but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: 80355b50dcec0bed3334160df82cb7829f9684f8
-- New SHA: 52665bb6e7f0bbe30ffabc59521a937072ecc9e2
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for parallel-hashmap but no changes to version or port version.
-- Version: 1.34
-- Old SHA: f72efb2dae42b2f746be8e239b00b707b3a61449
-- New SHA: 549369ee54770649ac89bd843a20b220c2b1691b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

This reverts commit 3b3f8da.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtl but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: 80355b50dcec0bed3334160df82cb7829f9684f8
-- New SHA: 52665bb6e7f0bbe30ffabc59521a937072ecc9e2
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Thomas1664 · 2022-03-08T15:49:48Z

@greg7mdp Everything OK?
If you ask yourself why CI is failing: This is again because you need to run vcpkg x-add-version gtl --overwrite-version and commit the result.

greg7mdp · 2022-03-08T16:06:37Z

This is again because you need to run vcpkg x-add-version gtl --overwrite-version and commit the result.

Thanks @Thomas1664 ! Just did it.

versions/g-/gtl.json

Thomas1664 · 2022-03-08T17:36:33Z

@greg7mdp Thanks. CI failures aren't your fault.

greg7mdp · 2022-03-08T17:48:55Z

Thanks. CI failures aren't your fault.

thanks, I was starting to worry I had messed up again!!!

* master: (64 commits) [baseline] [python3] fix bz2(d) search on linux (microsoft#23525) [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042) [earcut.hpp] New port (microsoft#23507) [libssh2] Fix deleted configfiles (microsoft#23509) [python3] Update to Python 3.10.2. (microsoft#23156) [qt5-webengine] Fix apply patch failed (microsoft#23484) [llvm] Fix LLVM install for 'utils' feature (microsoft#23399) [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357) [GTL] Add new port (microsoft#23400) [raylib] Fix cannot find -lglfw on Linux (microsoft#23348) [yato] fix arm build by updating (microsoft#23406) [ois] fix pkgconfig file not installed on windows (microsoft#23426) Fix the dependency of installing arrow with the parquet feature (microsoft#23423) [libjpeg-turbo] Fix usage when building static (microsoft#23427) [sentencepiece] Clarify supported triplets (microsoft#23438) [zpp-bits] Add new port (microsoft#23458) [lionkor-commandline] Add new port (microsoft#23471) [libde265] fix static linkage (microsoft#23479) [libheif] fix license (microsoft#23480) [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487) ...

greg7mdp and others added 10 commits March 3, 2022 16:02

[parallel-hashmap] update version to 1.34

1e35bd2

run vcpkg x-add-version --all and change version-string to version

3ff9dae

make suggested changes

7e9bb09

add changes suggested by @JonLui1993

db7b4b3

ran vcpkg x-add-version --all as suggested

d11feb7

update version

a8dad8f

update parallel-hashmap.json

fd6f30f

Merge branch 'microsoft:master' into master

412bffc

initial version

aa31a83

finish adding gtl port

ace3be7

github-actions bot requested changes Mar 6, 2022

View reviewed changes

Thomas1664 suggested changes Mar 6, 2022

View reviewed changes

ports/gtl/portfile.cmake Outdated Show resolved Hide resolved

ports/gtl/portfile.cmake Outdated Show resolved Hide resolved

add suggested changes (quotes around paths)

3c0e612

github-actions bot requested changes Mar 6, 2022

View reviewed changes

Thomas1664 approved these changes Mar 6, 2022

View reviewed changes

Update gtl.json

fddc849

github-actions bot approved these changes Mar 6, 2022

View reviewed changes

add quotes to paths as suggested.

3b3f8da

FrankXie05 assigned JonLiu1993 Mar 7, 2022

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 7, 2022

JonLiu1993 changed the title ~~Adding new GTL port. This is a new C++20 template library including updated versions of greg7mdp/parallel-hashmap and more~~ [GTL] Adding new port Mar 7, 2022

JonLiu1993 changed the title ~~[GTL] Adding new port~~ [GTL] Add new port Mar 7, 2022

JonLiu1993 reviewed Mar 7, 2022

View reviewed changes

ports/gtl/portfile.cmake Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Mar 7, 2022

JonLiu1993 approved these changes Mar 8, 2022

View reviewed changes

JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 8, 2022

JonLiu1993 added requires:author-response info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Mar 8, 2022

Update vcpkg.json

bccc76d

greg7mdp added 2 commits March 8, 2022 07:53

Merge branch 'microsoft:master' into master

96781b3

fix error: Error: String 1.00 is not a valid Relaxed version string…

22b9b10

… (semver with arbitrary numeric identifiers)

github-actions bot requested changes Mar 8, 2022

View reviewed changes

Revert "add quotes to paths as suggested."

a8fa0bc

This reverts commit 3b3f8da.

github-actions bot requested changes Mar 8, 2022

View reviewed changes

Update gtl.json

ba81f70

github-actions bot approved these changes Mar 8, 2022

View reviewed changes

Thomas1664 suggested changes Mar 8, 2022

View reviewed changes

versions/g-/gtl.json Outdated Show resolved Hide resolved

remove old version as suggested by @Thomas1664

3463fa5

github-actions bot approved these changes Mar 8, 2022

View reviewed changes

Thomas1664 approved these changes Mar 8, 2022

View reviewed changes

JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 9, 2022

vicroms merged commit fa93152 into microsoft:master Mar 11, 2022

Conversation

greg7mdp commented Mar 6, 2022

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Thomas1664 commented Mar 6, 2022

Uh oh!

greg7mdp commented Mar 6, 2022

Uh oh!

Uh oh!

greg7mdp commented Mar 8, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Thomas1664 commented Mar 8, 2022

Uh oh!

greg7mdp commented Mar 8, 2022

Uh oh!

Uh oh!

Thomas1664 commented Mar 8, 2022

Uh oh!

greg7mdp commented Mar 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?