Skip to content

Fix the dependency of installing arrow with the parquet feature#23423

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
ljishen:master
Mar 11, 2022
Merged

Fix the dependency of installing arrow with the parquet feature#23423
vicroms merged 1 commit intomicrosoft:masterfrom
ljishen:master

Conversation

@ljishen
Copy link
Contributor

@ljishen ljishen commented Mar 8, 2022

Describe the pull request

  • What does your PR fix?

Enabling the parquet feature will set the PARQUET_REQUIRE_ENCRYPTION flag. But building with this flag depends on RapidJSON: https://github.com/apache/arrow/blob/apache-arrow-7.0.0/cpp/cmake_modules/ThirdpartyToolchain.cmake#L271-L273

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@ghost
Copy link

ghost commented Mar 8, 2022

CLA assistant check
All CLA requirements met.

@LilyWangLL LilyWangLL self-assigned this Mar 8, 2022
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Mar 8, 2022
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 8, 2022
@vicroms vicroms merged commit 4c58b84 into microsoft:master Mar 11, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 14, 2022
* master: (64 commits)
  [baseline] [python3] fix bz2(d) search on linux (microsoft#23525)
  [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042)
  [earcut.hpp] New port (microsoft#23507)
  [libssh2] Fix deleted configfiles (microsoft#23509)
  [python3] Update to Python 3.10.2. (microsoft#23156)
  [qt5-webengine] Fix apply patch failed (microsoft#23484)
  [llvm] Fix LLVM install for 'utils' feature (microsoft#23399)
  [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357)
  [GTL] Add new port (microsoft#23400)
  [raylib] Fix cannot find -lglfw on Linux (microsoft#23348)
  [yato] fix arm build by updating (microsoft#23406)
  [ois] fix pkgconfig file not installed on windows (microsoft#23426)
  Fix the dependency of installing arrow with the parquet feature (microsoft#23423)
  [libjpeg-turbo] Fix usage when building static (microsoft#23427)
  [sentencepiece] Clarify supported triplets (microsoft#23438)
  [zpp-bits] Add new port (microsoft#23458)
  [lionkor-commandline] Add new port (microsoft#23471)
  [libde265] fix static linkage (microsoft#23479)
  [libheif] fix license (microsoft#23480)
  [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants