[libjpeg-turbo] Fix usage when building static#23427
Merged
vicroms merged 3 commits intomicrosoft:masterfrom Mar 11, 2022
Merged
[libjpeg-turbo] Fix usage when building static#23427vicroms merged 3 commits intomicrosoft:masterfrom
vicroms merged 3 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:port-bug
Contributor
Author
|
@reynoldsbd Can you please test this PR? Thanks. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dg0yt
reviewed
Mar 8, 2022
Contributor
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
LGTM, but I didn't test. I wish we had vcpkg_validate_cmake.
Member
|
@JackBoosY this works great, thanks! |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LilyWangLL
approved these changes
Mar 9, 2022
JackBoosY
added
the
info:needs-maintainer-attention
ekilmer
added a commit
to ekilmer/vcpkg
that referenced
this pull request
Mar 14, 2022
* master: (64 commits) [baseline] [python3] fix bz2(d) search on linux (microsoft#23525) [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042) [earcut.hpp] New port (microsoft#23507) [libssh2] Fix deleted configfiles (microsoft#23509) [python3] Update to Python 3.10.2. (microsoft#23156) [qt5-webengine] Fix apply patch failed (microsoft#23484) [llvm] Fix LLVM install for 'utils' feature (microsoft#23399) [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357) [GTL] Add new port (microsoft#23400) [raylib] Fix cannot find -lglfw on Linux (microsoft#23348) [yato] fix arm build by updating (microsoft#23406) [ois] fix pkgconfig file not installed on windows (microsoft#23426) Fix the dependency of installing arrow with the parquet feature (microsoft#23423) [libjpeg-turbo] Fix usage when building static (microsoft#23427) [sentencepiece] Clarify supported triplets (microsoft#23438) [zpp-bits] Add new port (microsoft#23458) [lionkor-commandline] Add new port (microsoft#23471) [libde265] fix static linkage (microsoft#23479) [libheif] fix license (microsoft#23480) [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since upstream allows building both dynamic and static libraries at the same time, we cannot patch to remove the static library suffix.
The generated cmake configuration file should synchronize the modification of the static library name.
Fixes #23422.