[ois] fix pkgconfig file not installed on windows#23426
[ois] fix pkgconfig file not installed on windows#23426vicroms merged 2 commits intomicrosoft:masterfrom
Conversation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/ois/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/ois/vcpkg.json b/ports/ois/vcpkg.json
index 4d9cf86..c73ac91 100644
--- a/ports/ois/vcpkg.json
+++ b/ports/ois/vcpkg.json
@@ -4,8 +4,8 @@
"port-version": 1,
"description": "Cross Platform Object Oriented Input Lib System. Meant to be very robust and compatible with many systems and operating systems.",
"homepage": "https://wgois.github.io/OIS/",
- "supports": "!(arm | arm64 | uwp)",
"license": "Zlib",
+ "supports": "!(arm | arm64 | uwp)",
"dependencies": [
{
"name": "vcpkg-cmake",After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5962cf5a3bfc2124e8de991a4e45a8edcb3b4c69 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/o-/ois.json b/versions/o-/ois.json
index 6f42d81..900e2b7 100644
--- a/versions/o-/ois.json
+++ b/versions/o-/ois.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "81da871c0f26427fd1612bdf027c8872bcab71b5",
+ "git-tree": "acfa0d3bb6e082f65e606f832bbeb23ac6a078b3",
"version": "1.5.1",
"port-version": 1
},|
Hold on, I did not fix debug suffix in pkgbuild file |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/ois/vcpkg.json b/ports/ois/vcpkg.json
index 4d9cf86..c73ac91 100644
--- a/ports/ois/vcpkg.json
+++ b/ports/ois/vcpkg.json
@@ -4,8 +4,8 @@
"port-version": 1,
"description": "Cross Platform Object Oriented Input Lib System. Meant to be very robust and compatible with many systems and operating systems.",
"homepage": "https://wgois.github.io/OIS/",
- "supports": "!(arm | arm64 | uwp)",
"license": "Zlib",
+ "supports": "!(arm | arm64 | uwp)",
"dependencies": [
{
"name": "vcpkg-cmake",After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5962cf5a3bfc2124e8de991a4e45a8edcb3b4c69 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/o-/ois.json b/versions/o-/ois.json
index f01d791..39d8df3 100644
--- a/versions/o-/ois.json
+++ b/versions/o-/ois.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "2041652d38eabf31ad8008aa5f7972765257011a",
+ "git-tree": "79d79b0c5901492572044ad873cdf4df864accea",
"version": "1.5.1",
"port-version": 1
},There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/ois/vcpkg.json b/ports/ois/vcpkg.json
index 4d9cf86..c73ac91 100644
--- a/ports/ois/vcpkg.json
+++ b/ports/ois/vcpkg.json
@@ -4,8 +4,8 @@
"port-version": 1,
"description": "Cross Platform Object Oriented Input Lib System. Meant to be very robust and compatible with many systems and operating systems.",
"homepage": "https://wgois.github.io/OIS/",
- "supports": "!(arm | arm64 | uwp)",
"license": "Zlib",
+ "supports": "!(arm | arm64 | uwp)",
"dependencies": [
{
"name": "vcpkg-cmake",After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5962cf5a3bfc2124e8de991a4e45a8edcb3b4c69 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/o-/ois.json b/versions/o-/ois.json
index 6f42d81..900e2b7 100644
--- a/versions/o-/ois.json
+++ b/versions/o-/ois.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "81da871c0f26427fd1612bdf027c8872bcab71b5",
+ "git-tree": "acfa0d3bb6e082f65e606f832bbeb23ac6a078b3",
"version": "1.5.1",
"port-version": 1
},|
We need to check the pkgconfig files. |
|
@maz-1, Thanks for posting this issue,I cloned your branch to the local and then use the commands ''./vcpkg install osi --debug" and "./vcpkg install osi" after installation, it is not in the F:\test-pr\vcpkg\packages\osi_x86-windows path Found the pkgconfig file, have you tested it locally? |
I think you mistaken the package name, it's ois not osi |
Sorry, I made a mistake, I re-tested with the correct package name and checked the .pc file in F:\test-pr\vcpkg\packages\ois_x86-windows\debug\lib\pkgconfig, Looks correct |
* master: (64 commits) [baseline] [python3] fix bz2(d) search on linux (microsoft#23525) [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042) [earcut.hpp] New port (microsoft#23507) [libssh2] Fix deleted configfiles (microsoft#23509) [python3] Update to Python 3.10.2. (microsoft#23156) [qt5-webengine] Fix apply patch failed (microsoft#23484) [llvm] Fix LLVM install for 'utils' feature (microsoft#23399) [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357) [GTL] Add new port (microsoft#23400) [raylib] Fix cannot find -lglfw on Linux (microsoft#23348) [yato] fix arm build by updating (microsoft#23406) [ois] fix pkgconfig file not installed on windows (microsoft#23426) Fix the dependency of installing arrow with the parquet feature (microsoft#23423) [libjpeg-turbo] Fix usage when building static (microsoft#23427) [sentencepiece] Clarify supported triplets (microsoft#23438) [zpp-bits] Add new port (microsoft#23458) [lionkor-commandline] Add new port (microsoft#23471) [libde265] fix static linkage (microsoft#23479) [libheif] fix license (microsoft#23480) [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487) ...
Describe the pull request
What does your PR fix?
Fixes pkgconfig file not installed on windows
Which triplets are supported/not supported? Have you updated the CI baseline?
not updated, sould be same as before
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?