[vcpkg baseline][libao] Disable dlfcn check under windows#23235
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom Feb 23, 2022
Merged
[vcpkg baseline][libao] Disable dlfcn check under windows#23235BillyONeal merged 3 commits intomicrosoft:masterfrom
BillyONeal merged 3 commits intomicrosoft:masterfrom
Conversation
Contributor
|
Does it need a patch, or could you just pass a corresponding cache vale ( |
Contributor
Author
|
@dg0yt Thanks for your guidance! |
JackBoosY
suggested changes
Feb 23, 2022
JackBoosY
approved these changes
Feb 23, 2022
Contributor
JackBoosY
left a comment
There was a problem hiding this comment.
LGTM if the tests passed.
Contributor
|
@vicroms Please consider to merge this PR first. |
dg0yt
reviewed
Feb 24, 2022
| @@ -1,5 +1,7 @@ | |||
| set(NO_DLFCN ) | |||
Contributor
There was a problem hiding this comment.
This is bad CMake style. It unsets the variable in the current scope, unhiding a possible value from a parent scope. For a clean variable, always use:
set(VAR "")
Contributor
There was a problem hiding this comment.
ekilmer
added a commit
to ekilmer/vcpkg
that referenced
this pull request
Feb 27, 2022
* master: (57 commits) [vcpkg-tools] update cmake and git (windows only) (microsoft#22985) Update vcpkg tool to 2022-02-24. (microsoft#23162) [vcpkg baseline] Move cspice headers (microsoft#23272) Fixed inaccurate Chinese words (microsoft#23179) [vcpkg] Add fixed changelog generator. (microsoft#23255) [authentication.md] Add Jenkins section (microsoft#23226) [vcpkg] Meson osx sysroot (microsoft#21772) [pkgconf] enable search for system libs on linux (microsoft#23010) [yasm/yasm-tool] Incorporate yasm-tool into yasm (microsoft#23218) [lapack-reference] Update to 3.10 (microsoft#23228) [skia] Arm64 for skia on osx (microsoft#23222) [libfido2] Update to 1.10.0 (microsoft#23241) [Tracy] Fixing issue where version 0.7.8 was pulling the wrong version (microsoft#23061) [libgpiod] Add new port. (microsoft#23221) [drogon] Update to 1.7.5 (microsoft#23227) [tinyexif] Remove from fail list. (microsoft#23163) [vcpkg docs][ES] Sync with English readme (microsoft#19834) (microsoft#22618) [vcpkg baseline][libao] Disable dlfcn check under windows (microsoft#23235) [OpenCV] upgrade to v4.5.5 (microsoft#22801) [libcurl-simple-https] New port (microsoft#22917) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
In an internal CI test, libao installation failed with following errors:
This issue only occurs when dlfcn-win32 installed before libao in Windows. Libao always check dlfcn.h and enable the macro HAVE_DLOPEN if dlfcn.h is exists, then the DIR struct will be compiled, in windows environment this will cause the above errors to appear.
For fixing this issue, I passed a cache variable to disable the search of dlfcn under windows
No feature need to be tested.