Skip to content

Update authentication.md#23226

Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom
petr-tichy:patch-1
Feb 24, 2022
Merged

Update authentication.md#23226
ras0219-msft merged 1 commit intomicrosoft:masterfrom
petr-tichy:patch-1

Conversation

@petr-tichy
Copy link
Contributor

This documents Jenkins authentication option using forwarding the GIT_ASKPASS environment variable. This should be default.

@JackBoosY JackBoosY added the category:documentation To resolve the issue, documentation will need to be updated label Feb 23, 2022
@JackBoosY
Copy link
Contributor

I haven't used jekens for years, @ras0219-msft do you have any opinions?

@JackBoosY JackBoosY added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Feb 23, 2022
@ras0219-msft
Copy link
Contributor

This generally looks good to me, though it begs the question of whether we should pass GIT_ASKPASS through by default.

Regardless I think this is likely an improvement until we decide to do so. Thanks a bunch for the PR!

@ras0219-msft ras0219-msft merged commit d699e78 into microsoft:master Feb 24, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Feb 27, 2022
* master: (57 commits)
  [vcpkg-tools] update cmake and git (windows only) (microsoft#22985)
  Update vcpkg tool to 2022-02-24. (microsoft#23162)
  [vcpkg baseline] Move cspice headers (microsoft#23272)
  Fixed inaccurate Chinese words (microsoft#23179)
  [vcpkg] Add fixed changelog generator. (microsoft#23255)
  [authentication.md] Add Jenkins section (microsoft#23226)
  [vcpkg] Meson osx sysroot (microsoft#21772)
  [pkgconf] enable search for system libs on linux (microsoft#23010)
  [yasm/yasm-tool] Incorporate yasm-tool into yasm (microsoft#23218)
  [lapack-reference] Update to 3.10 (microsoft#23228)
  [skia] Arm64 for skia on osx (microsoft#23222)
  [libfido2] Update to 1.10.0 (microsoft#23241)
  [Tracy] Fixing issue where version 0.7.8 was pulling the wrong version (microsoft#23061)
  [libgpiod] Add new port. (microsoft#23221)
  [drogon] Update to 1.7.5 (microsoft#23227)
  [tinyexif] Remove from fail list. (microsoft#23163)
  [vcpkg docs][ES] Sync with English readme (microsoft#19834) (microsoft#22618)
  [vcpkg baseline][libao] Disable dlfcn check under windows (microsoft#23235)
  [OpenCV] upgrade to v4.5.5 (microsoft#22801)
  [libcurl-simple-https] New port (microsoft#22917)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:documentation To resolve the issue, documentation will need to be updated requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants