[drogon] Update to 1.7.5

[an-tao]

No description provided.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5cf60186a241e84e8232641ee973395d4fde90e1 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 7d82610..f732d2c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1914,7 +1914,7 @@
     },
     "drogon": {
       "baseline": "1.7.5",
-      "port-version": 0
+      "port-version": 2
     },
     "dtl": {
       "baseline": "1.19",
diff --git a/versions/d-/drogon.json b/versions/d-/drogon.json
index f801d8d..8e82e4a 100644
--- a/versions/d-/drogon.json
+++ b/versions/d-/drogon.json
@@ -3,7 +3,7 @@
     {
       "git-tree": "dc133ea44f319f9a9d953cc2d26823b2d3eb96bf",
       "version-semver": "1.7.5",
-      "port-version": 0 
+      "port-version": 2
     },
     {
       "git-tree": "b7be1868461c479ff45609e892bc5de9adf42258",

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/drogon/vcpkg.json b/ports/drogon/vcpkg.json
index 52fa1d9..f6e70f7 100644
--- a/ports/drogon/vcpkg.json
+++ b/ports/drogon/vcpkg.json
@@ -1,7 +1,6 @@
 {
   "name": "drogon",
   "version-semver": "1.7.5",
-  "port-version": 0,
   "description": "A C++14/17 based HTTP web application framework running on Linux/macOS/Unix/Windows",
   "homepage": "https://github.com/an-tao/drogon",
   "documentation": "https://drogon.docsforge.com/master/overview/",

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5cf60186a241e84e8232641ee973395d4fde90e1 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/d-/drogon.json b/versions/d-/drogon.json
index 089d44c..7e0e9d9 100644
--- a/versions/d-/drogon.json
+++ b/versions/d-/drogon.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "09f089fde4ce6145744e0c164031464c39f0ad35",
+      "git-tree": "a66c2bb4632ab86589f1cabed26607d510ae2eba",
       "version-semver": "1.7.5",
-      "port-version": 0 
+      "port-version": 0
     },
     {
       "git-tree": "b7be1868461c479ff45609e892bc5de9adf42258",

[JonLiu1993]

All features are tested successfully in the following triplet:

• x86-windows
• x64-windows
• x64-windows-static

[kotori2]

This PR breaks Drogon linking on Linux.

cmake -DCMAKE_TOOLCHAIN_FILE=/home/kotori/vcpkg/scripts/buildsystems/vcpkg.cmake ..
-- Running vcpkg install
-- Running vcpkg install - done
-- Found Jsoncpp: /home/kotori/untitled2/build/vcpkg_installed/x64-linux/include  
-- jsoncpp verson:1.9.5
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Found OpenSSL: /home/kotori/untitled2/build/vcpkg_installed/x64-linux/lib/libcrypto.a (found version "1.1.1n")  
-- Found c-ares: /home/kotori/untitled2/build/vcpkg_installed/x64-linux/include  
-- Found UUID: /home/kotori/untitled2/build/vcpkg_installed/x64-linux/lib/libuuid.a
-- Found ZLIB: /home/kotori/untitled2/build/vcpkg_installed/x64-linux/lib/libz.a (found version "1.2.11") 
-- Found SQLite3: /home/kotori/untitled2/build/vcpkg_installed/x64-linux/lib/libsqlite3.a  
-- Found Brotli: /home/kotori/untitled2/build/vcpkg_installed/x64-linux/lib/libbrotlidec-static.a  
-- Looking for C++ include filesystem
-- Looking for C++ include filesystem - found
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED - Success
-- Configuring done
CMake Error at /home/kotori/vcpkg/scripts/buildsystems/vcpkg.cmake:557 (_add_executable):
  Target "untitled2" links to target "unofficial::libmariadb" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:6 (add_executable)


-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

CMakeLists.txt

cmake_minimum_required(VERSION 3.16.3)
project(untitled2)

set(CMAKE_CXX_STANDARD 20)
find_package(Drogon CONFIG REQUIRED)
add_executable(untitled2 main.cpp)
target_link_libraries(untitled2 Drogon::Drogon)

[an-tao]

did you upgrade the dependencies of drogon in vcpkg?

[kotori2]

did you upgrade the dependencies of drogon in vcpkg?

Yes.

$ cat ../vcpkg.json 
{
  "name": "test",
  "version-string": "0.1",
  "port-version": 1,
  "homepage": "",
  "description": "",
  "dependencies": [
    {
      "name": "drogon",
      "features": [ "ctl", "mysql", "sqlite3" ]
    }
  ],
  "builtin-baseline": "f3a68220a5b48132e53708ed76411f04976a911a"
}

982cf2b (previous commit) works without any issue.

[dg0yt]

IIUC we lack the initialization of MySQL_FOUND now. That's why the find_dependency(unofficial-libmariadb) isn't called in the exported config.

In the context of GDAL, I learned to appreciate the extended signature of find_package. If a project needs a MySQL_FOUND, a patch could use find_package(MySQL NAMES unofficial-mariadb). This would allow smaller patches with less side effects.